Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search area limit #47

Merged
merged 10 commits into from
Nov 13, 2019
Merged

Conversation

joziesands
Copy link
Contributor

  • Added a dropdown to the search bar to select max-distance from event
  • Added submit button to the zip code search
  • A search that doesn't return any events creates a card with options to host your own event or join a virtual event with links to the campaign website
  • A search that doesn't return any events also sets the map view to the original lat/long/zoom

@jasonkalmeida
Copy link
Collaborator

Hey @joziesands! A couple things I found in testing your live version of this PR.

  1. As I stated previously, I love the new design for the submit button - definitely helps differentiate to the user between Zipcode Search and Geolocation search.

  2. Have you tested this on mobile? As of now, at least in my testing, the search bar gets very cramped and UI elements start to go a bit haywire.

  3. When it comes to the UX of the search area, I do think throwing the search distance starts to get the bar a little cramped. A possible alternative (and would love to hear your feedback), is maybe after a user searches, have at the bottom of the list or somewhere else a "click to expand" to increment the radius by a fixed amount?

To help us tackle these issues, can you create 2 separate PRs for the two features - #6 and #44 - this way the discussions on each can be focused and the two features can be pushed on their own times.

@joziesands
Copy link
Contributor Author

joziesands commented Oct 28, 2019

Thanks for the feedback!

  • I will make a PR for Redesign Search Bar To Clarify Options #44 ... hopefully today, maybe tomorrow.

  • I was concerned about cramping on mobile. I tested it on a Galaxy S8 while I was building it, and it was fine. I just had someone with an iPhone 8 test it and she said the O in GO was cut off ... so I'll look into it.
    -- If you know of a way to get an accurate simulation of a mobile device on a desktop, please let me know. The Chrome dev tools option doesn't seem to trigger the media query or something... it doesn't switch to 100% width for the search bar.

  • I'll implement the 'click to expand' option with default 75 mi with an additional 75 for each expansion and we can see how it feels.
    -- My only concern with incrementing the search radius by a fixed amount is that it will either be overwhelming people in populated areas or it will make people in rural areas run 3-4 searches depending on how many miles we add each time.
    -- I live in a fairly rural area, and right now the nearest event is 75 mi away, which is a totally reasonable distance to drive for an event around here. But I assume someone in a heavily populated area would not be interested in an event 75 miles away and might want to narrow their search.

@joziesands
Copy link
Contributor Author

What do you think about this, @jasonkalmeida ? The "showing events..." bar is only visible after the first search.
The form would resubmit when the GO button is pressed or the range selection is changed.

Screen Shot 2019-10-30 at 8 18 26 PM

@jasonkalmeida jasonkalmeida merged commit 3e9bfac into techforwarren:master Nov 13, 2019
@joegoldbeck joegoldbeck mentioned this pull request Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants