Remove not needed statements that are also stored in SqlStatementRepository #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

sippsolutions wants to merge 1 commit into techdivision:18.x from sippsolutions:patch-1

Member

sippsolutions commented Mar 11, 2020

Remove not needed statements that are also stored in SqlStatementRepository


          Remove not needed statements that are also stored in SqlStatementRepo…

aab4486

…sitory

Member Author

sippsolutions commented Mar 11, 2020

wagnert requested changes

View reviewed changes

Member

wagnert left a comment

Beside the comments in the code, it would be nice, if you can also delete the appropriate constants in the class, if not needed anymore.

src/Utils/SqlStatementKeys.php

-                                  is_autogenerated = :is_autogenerated,
-                                  metadata = :metadata
-                            WHERE url_rewrite_id = :url_rewrite_id',
-                      SqlStatementKeys::CREATE_URL_REWRITE_PRODUCT_CATEGORY =>

Member

wagnert Mar 12, 2020

This is not available in 'TechDivision\Import\Utils\SqlStatements' and can therefor not been deleted.

src/Utils/SqlStatementKeys.php

-                           VALUES (:url_rewrite_id,
-                                   :category_id,
-                                   :product_id)',
-                      SqlStatementKeys::UPDATE_URL_REWRITE_PRODUCT_CATEGORY =>

Member

wagnert Mar 12, 2020

This is not available in 'TechDivision\Import\Utils\SqlStatements' and can therefor not been deleted.

src/Utils/SqlStatementKeys.php

-                              SET category_id = :category_id,
-                                  product_id = :product_id
-                            WHERE url_rewrite_id = :url_rewrite_id',
-                      SqlStatementKeys::DELETE_URL_REWRITE_PRODUCT_CATEGORY =>

Member

wagnert Mar 12, 2020

This is not available in 'TechDivision\Import\Utils\SqlStatements' and can therefor not been deleted.

src/Utils/SqlStatementKeys.php

-                          'DELETE
-                             FROM catalog_url_rewrite_product_category
-                            WHERE url_rewrite_id = :url_rewrite_id',
-                      SqlStatementKeys::URL_REWRITE_PRODUCT_CATEGORY =>

Member

wagnert Mar 12, 2020

This is not available in 'TechDivision\Import\Utils\SqlStatements' and can therefor not been deleted.

src/Utils/SqlStatementKeys.php

-                          'SELECT *
-                             FROM catalog_url_rewrite_product_category
-                            WHERE url_rewrite_id = :url_rewrite_id',
-                      SqlStatementKeys::URL_REWRITES_BY_SKU =>

Member

wagnert Mar 12, 2020

This is not available in 'TechDivision\Import\Utils\SqlStatements' and can therefor not been deleted.

src/Utils/SqlStatementKeys.php

-                            WHERE t1.sku = :sku
-                              AND t2.entity_id = t1.entity_id
-                              AND t2.entity_type = \'product\'',
-                      SqlStatementKeys::URL_REWRITE_PRODUCT_CATEGORIES_BY_SKU =>

Member

wagnert Mar 12, 2020

This is not available in 'TechDivision\Import\Utils\SqlStatements' and can therefor not been deleted.

wagnert self-assigned this

wagnert added the enhancement label

Member Author

sippsolutions commented Mar 12, 2020

the deleted code seems to be copied from the SqlStatementRepository class.
The constructor tries to assign data to a variable called "preparedStatements" that's not available in SqlStatementKeys classes, but is available in Repositories.
Are you sure the mentioned keys are still needed?
If they are needed, a $preparedStatements private variable should be declared, otherwise the code should be removed (and the constants you mentioned aswell).

Member

wagnert commented Mar 13, 2020

Will be fixed with the next release.

wagnert closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels