fix: resolve Blender 3.6+ PySide6 compatibility issues #128
Conversation
|
@hannesdelbeke Please have a look. |
|
afraid i'm not able to reproduce the error you have. |
bqt/__init__.py
Outdated
| except (AttributeError, TypeError): | ||
| # If direct setting fails, use wrapper | ||
| try: | ||
| bpy.app.translations = _create_translations_wrapper(translations) |
There was a problem hiding this comment.
I think that in all cases that setattr would fail so would direct assignment. I think this whole except block can be removed.
bqt/__init__.py
Outdated
| except Exception: | ||
| pass | ||
| return False | ||
| except Exception: | ||
| return False |
There was a problem hiding this comment.
I am not a fan catching blanket exceptions like this.
Did you add these because you want to be sure that your change is 100% safe if something goes wrong? Or do you use this to actually catch any errors ?
I think all exception handling should be removed from _patch_bpy_translations_in_sys_modules
|
In additions to # CRITICAL: Fix bpy.app.* modules BEFORE importing any Qt/PySide modules
# This prevents Shiboken from failing when it tries to introspect bpy.app.* modules
import sys
def _create_wrapper(original, cls_name):
"""Create a compatibility wrapper for bpy.app.*"""
class Wrapper:
def __init__(self, orig):
self._orig = orig
def __getattr__(self, name):
# Provide missing attributes that Shiboken expects
if name == '__name__':
return f'bpy.app.{cls_name}'
elif name == '__module__':
return 'bpy.app'
elif name == '__qualname__':
return cls_name
elif name == '_ne_':
return lambda x, y: x != y
elif name == '__doc__':
return f'Blender {cls_name} compatibility wrapper'
else:
return getattr(self._orig, name)
def __setattr__(self, name, value):
if name == '_orig':
super().__setattr__(name, value)
else:
setattr(self._orig, name, value)
def __dir__(self):
orig_attrs = (dir(self._orig)
if hasattr(self._orig, '__dir__') else [])
extra_attrs = ['__name__', '__module__', '__qualname__',
'_ne_', '__doc__']
return list(set(orig_attrs + extra_attrs))
return Wrapper(original)
def _patch_bpy_module_in_sys_modules(name):
"""Directly patch bpy.app.* modules in sys.modules if it exists"""
# Check if bpy.app.* module is already in sys.modules
if f"bpy.app.{name}" in sys.modules:
module = sys.modules[f"bpy.app.{name}"]
required_attrs = ['__name__', '__module__', "__qualname__", "_ne_"]
# Check if any required attributes are missing
if any(not hasattr(module, attr) for attr in required_attrs):
wrapped = _create_wrapper(module, name)
sys.modules[f"bpy.app.{name}"] = wrapped
return True
return False
def _fix_existing_module(name):
"""Fix bpy.app.* modules if it already exists"""
import bpy
if not hasattr(bpy.app, name):
return
module = getattr(bpy.app, name)
required_attrs = ['__name__', '__module__', '__qualname__']
# Check if any required attributes are missing
if any(not hasattr(module, attr) for attr in required_attrs):
try:
# Try direct attribute setting first
attrs_to_add = {
'__name__': f'bpy.app.{name}',
'__module__': 'bpy.app',
'__qualname__': name,
}
for attr_name, attr_value in attrs_to_add.items():
if not hasattr(module, attr_name):
setattr(module, attr_name, attr_value)
except (AttributeError, TypeError):
pass
# Apply patches immediately - order matters!
# Check sys.modules first
_patch_bpy_module_in_sys_modules("translations")
_patch_bpy_module_in_sys_modules("handlers")
# Fix existing translations if available
_fix_existing_module("translations")
_fix_existing_module("handlers") |
- Add generic bpy.app module wrapper for Shiboken compatibility - Patch both bpy.app.translations and bpy.app.handlers (fixes techartorg#127) - Fix logging.basicConfig encoding parameter for Python < 3.9 (Blender 2.83) - Use __slots__ for memory optimization in wrapper class Thanks to @Jerakin for the suggestions in PR techartorg#128 and techartorg#133 Fixes: techartorg#127 Related: techartorg#133
|
I've updated the fix based on @Jerakin's excellent suggestions from PR #128 and #133. The new implementation includes: Changes: Generic wrapper for bpy.app submodules - Refactored _create_translations_wrapper to a generic _create_bpy_app_wrapper that supports any bpy.app submodule ✅ Blender 2.83 (Python 3.7) |
|
thanks for the work in fixing this issue What's the issue we're solving? increasing complexity move code out of init |
|
i just noticed you tested with Blender 2.83 (Python 3.7), do we want to support such an old version of blender in bqt? |
|
I only noticed this error on versions less than 4.0 But Loonghao mentioned that "4.1, 4.2 (confirmed affected on Windows)" in the issue report. So I don't think it's "safe" to dismiss the issue out right. Just cause we can't reproduce it doesn't mean that it doesn't happen. I do however think that if this patch is needed it should be moved into it's own file and imported into this location, instead of having it all in (p.s. they might be using AI if they are not comfortable with English.) |
hm that made me think, is that why we can't repro, because our english blender never triggers i also noticed in the screenshots in the original issue, that all the errors happen in the fbx import/export addon. i assumed it errored when enabling the bqt addon. |
# Conflicts: # bqt/__init__.py
|
i moved it to a separate file, however still would like to understand and repro it |
bqt/pyside_compatibility.py
Outdated
|
Found some more information.
For me using a newer version of PySide Works. It only happens on earlier versions of pyside for me cause 6.6 drops py37 support which older blender versions are using.
@loonghao Could you try and see if installing PySide 6.6 or higher resolves this issue? |
3 participants
Fixes compatibility issues where PySide6/Shiboken fails during initialization due to missing name, module, qualname, and ne attributes on the bpy.app.translations object. Issue affects all Blender 3.1+ versions when bqt plugin is enabled.
This enhanced approach provides early intervention at module registration level to prevent AttributeError from occurring in other modules that import from bpy.app.translations.
Fix #127