-
Notifications
You must be signed in to change notification settings - Fork 0
Ozzmeister00 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ozzmeister00
wants to merge
43
commits into
main
Choose a base branch
from
ozzmeister00
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ozzmeister00 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nge to Mapping, and making Mappings
I wasn't happy with the bifurcated way testing was handled in the most recent version of my solver, and since I'm doing a lot of AoC outside of my usual pyCharm environment I wanted to add a few more tools and systems to support that. Solvers now get instantiated, and if no RawData is passed in, it'll load that day's input data. a day should have a test_dayXX in the tests module, and when you want to run a day, it'll first run the tests and if the tests succeed, it'll proceed with actually solving. so now all testing (either on the known test data, or on smaller tests) happens in the unittests. This better supports the possibility of multiple test cases/answers within the puzzle itself. This also eliminates the boilerplate if not data: data = self.processed step that was at the top of all the solver functions.
Main now first runs the day's tests and only runs the day if the tests were successful. RunTests now assumes you want to run all of the tests, and will only run a specific day if the --day or -d flag is passed in.
Happy that I knew immediately to not brute-force this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.