-
Notifications
You must be signed in to change notification settings - Fork 0
[Feat] #277 - 홈 뷰, 공고 상세 뷰 ,검색 뷰 플레이스홀더 구현 했습니다. #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The head ref may contain hidden characters: "Feat/#277-\uD648_\uC0C1\uC138_\uD50C\uB808\uC774\uC2A4\uD640\uB354"
Conversation
wjdalswl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인했슴니다! 수고하셨어요~~
| extension CompanyInfoTableViewCell { | ||
| func bind(with companyInfo: CompanyInfoModel) { | ||
| companyImageView.setImage(with: companyInfo.companyImage ?? "placeholder_image", placeholder: "placeholder_image") | ||
| companyImageView.setImage(with: companyInfo.companyImage ?? "placeholder_image", placeholder: "img_post_placeHolder") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
companyInfo.companyImage 값이 없을때도 "placeholder_image"말고 "img_post_placeHolder" 써도 되지 않을까요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
값이 없을 때 <- 빈 이미지
값이 뜨기 전 <- 플레이 홀 더 이미지
이렇게 분리해서 생각을 했는데, 통일할지는 디자인 선생님들에게 물어봐야 할 것 같네요!
| override func prepareForReuse() { | ||
| super.prepareForReuse() | ||
|
|
||
| self.jobCardCoverImage.image = UIImage(resource: .imgPostPlaceHolder) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이러면 이제 이미지 밀리는거 해결 되나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prepareForReuse() 호출할 때, 기본값을 넣어주면 해결되더라고요!
더 좋은 방법이 있는지는 공부하면서 알아봐야 할 것 같습니다.
🩵 Issue
close #277
💙 변경된 내용
📘 ScreenShot