Skip to content
This repository has been archived by the owner on Nov 27, 2020. It is now read-only.

Driver can enable or disable PhantomJS cookies #300

Merged
merged 1 commit into from
Apr 19, 2013
Merged

Driver can enable or disable PhantomJS cookies #300

merged 1 commit into from
Apr 19, 2013

Conversation

mfrost
Copy link
Contributor

@mfrost mfrost commented Apr 15, 2013

As of 1.7, PhantomJS allows its CookieJar to be enabled or disabled using the cookiesEnabled function. This commit adds access to that from the driver using a similarly named cookies_enabled= method.

For more information on the API, check out:

https://github.com/ariya/phantomjs/wiki/API-Reference-phantom#cookiesenabled-boolean

As of 1.7, PhantomJS allows its `CookieJar` to be enabled or disabled using the
`cookiesEnabled` function. This commit adds access to that from the driver
using a similarly named `cookies_enabled=` method.

For more information on the API, check out:

https://github.com/ariya/phantomjs/wiki/API-Reference-phantom#cookiesenabled-boolean
@route
Copy link
Contributor

route commented Apr 19, 2013

This is it, could be merged?

@jonleighton
Copy link
Contributor

Why do you need this feature?

@mfrost
Copy link
Contributor Author

mfrost commented Apr 19, 2013

@jonleighton was that question for me?

If so, we're working a feature that shows a warning when cookies are disabled. Searching turned up a few techniques for using /dev/null as the location for the --cookies-file. Didn't have any luck with that method, and found that PhantomJS actually had support for disabling cookies altogether.

@jonleighton
Copy link
Contributor

@mfrost cool, makes sense. will merge, thanks.

jonleighton added a commit that referenced this pull request Apr 19, 2013
Driver can enable or disable PhantomJS cookies
@jonleighton jonleighton merged commit da9bafc into teampoltergeist:master Apr 19, 2013
@mfrost mfrost deleted the cookies_enabled branch April 19, 2013 21:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants