Feat simplify config #635
Merged
Feat simplify config #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [github.com/labstack/echo/v4](https://github.com/labstack/echo) from 4.10.0 to 4.10.2. - [Release notes](https://github.com/labstack/echo/releases) - [Changelog](https://github.com/labstack/echo/blob/master/CHANGELOG.md) - [Commits](labstack/echo@v4.10.0...v4.10.2) --- updated-dependencies: - dependency-name: github.com/labstack/echo/v4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…v4-4.10.2' into feat-simplify-config
like-a-bause
commented
Mar 7, 2023
|
When testing please try out in a X-Domain Setting. I pushed a docker container: |
like-a-bause
requested review from
FreddyDevelop,
lfleischmann and
bjoern-m
and removed request for
FreddyDevelop and
lfleischmann
|
The |
… Ip address won't work as origin.
|
Needed changes:
|
like-a-bause
commented
Apr 11, 2023
Co-authored-by: lfleischmann <67686424+lfleischmann@users.noreply.github.com>
lfleischmann
approved these changes
Apr 12, 2023
lfleischmann
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with simplifying the Cors config on the public endpoint.
Implementation
Tests
Todos
Additional context