Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOOLEAN fix and various stuff #38

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Boris-Barboris
Copy link

1). BOOLEAN was broken, it was transfered in text mode instead of binary
2). scope ref did not compile on ldc
3). getOids from PGParameters returns range instead of allocating int array
4). (MAY BREAK SOMETHING) removed AA in PGParameters and stored them as array. I've got serious bugs in AA implementation, when columns were pushed to DB out of order and some fields were assigned to another ones during paramethrized queries. Array is simple and reliable. And no need to sort stuff. Just add parameters one by one in correct order and everything will be fine.
5). synchronized was not needed in PGConnection, it's already supposed to be protected by connection pooling.
6). simple "BEGIN" transaction method PGConnection.begin_default without parameters, when you don't want to explicitly pass perameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant