Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1). BOOLEAN was broken, it was transfered in text mode instead of binary
2). scope ref did not compile on ldc
3). getOids from PGParameters returns range instead of allocating int array
4). (MAY BREAK SOMETHING) removed AA in PGParameters and stored them as array. I've got serious bugs in AA implementation, when columns were pushed to DB out of order and some fields were assigned to another ones during paramethrized queries. Array is simple and reliable. And no need to sort stuff. Just add parameters one by one in correct order and everything will be fine.
5). synchronized was not needed in PGConnection, it's already supposed to be protected by connection pooling.
6). simple "BEGIN" transaction method PGConnection.begin_default without parameters, when you don't want to explicitly pass perameters.