Selenium driver reset synchronous #1672
Merged
+78
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think that this was a futile attempt to resolve problems with restting sessions which should be much better handled by the addition of `wait_for_pending_requests`. Closes teamcapybara#1670
twalpole
force-pushed
the
selenium_driver_reset_synchronous
branch
from
c7caa6f to
8054029
Compare
twalpole
force-pushed
the
selenium_driver_reset_synchronous
branch
from
8054029 to
1e4529b
Compare
Collaborator
|
This is amazing! Thank you so much for putting so much effort into this. |
Member
Author
|
@jnicklas you're welcome -- I tried it with capybara-webkit and poltergeist and the removal of the assert_no_selector in Session#reset! didn't appear to affect them, so hopefully it doesn't --- I'm sure we'll hear if it does :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure
#resetfor the selenium driver is synchronous and handles modals that may appear.