feat: automatically populate the allowScripts field

scopes/dependencies/dependency-resolver/dependency-installer.ts

@@ -6,7 +6,7 @@ import type { ComponentMap } from '@teambit/component';
 import { type DependenciesGraph } from '@teambit/objects';
 import type { Logger } from '@teambit/logger';
 import type { PathAbsolute } from '@teambit/toolbox.path.path';
-import type { PeerDependencyRules, ProjectManifest } from '@pnpm/types';
+import type { PeerDependencyRules, ProjectManifest, IgnoredBuilds } from '@pnpm/types';
 import { MainAspectNotInstallable, RootDirNotDefined } from './exceptions';
 import type { PackageManager, PackageManagerInstallOptions, PackageImportMethod } from './package-manager';
 import type { WorkspacePolicy } from './policy';
@@ -152,7 +152,7 @@ export class DependencyInstaller {
     componentDirectoryMap: ComponentMap<string>,
     options: InstallOptions = DEFAULT_INSTALL_OPTIONS,
     packageManagerOptions: PackageManagerInstallOptions = DEFAULT_PM_INSTALL_OPTIONS
-  ): Promise<{ dependenciesChanged: boolean }> {
+  ): Promise<{ dependenciesChanged: boolean; ignoredBuilds?: IgnoredBuilds }> {
     const args = {
       componentDirectoryMap,
       options,

scopes/dependencies/dependency-resolver/dependency-resolver-workspace-config.ts

@@ -187,7 +187,7 @@ export interface DependencyResolverWorkspaceConfig {
    * Fine-grained control over dependency lifecycle scripts. Allows explicitly permitting (true), blocking (false), or warning ('warn')
    * for specific dependencies' "preinstall", "install", and "postinstall" scripts during installation.
    */
-  allowScripts?: Record<string, boolean | 'warn'>;
+  allowScripts?: Record<string, boolean | string>;
 
   /**
    * Set this to true in order to allow all dependencies to run install scripts.

scopes/dependencies/dependency-resolver/dependency-resolver.main.runtime.ts

@@ -1028,7 +1028,7 @@ export class DependencyResolverMain {
     };
   }
 
-  updateAllowedScripts(newAllowedScripts: Record<string, boolean>): void {
+  updateAllowedScripts(newAllowedScripts: Record<string, boolean | string>): void {
     this.config.allowScripts = {
       ...this.config.allowScripts,
       ...newAllowedScripts,

scopes/dependencies/dependency-resolver/package-manager.ts

@@ -1,5 +1,5 @@
 import { PeerDependencyIssuesByProjects } from '@pnpm/core';
-import type { PeerDependencyRules, ProjectManifest, DependencyManifest } from '@pnpm/types';
+import type { PeerDependencyRules, ProjectManifest, DependencyManifest, IgnoredBuilds } from '@pnpm/types';
 import type { ComponentID, ComponentMap, Component } from '@teambit/component';
 import { type DependenciesGraph } from '@teambit/objects';
 import type { Registries } from '@teambit/pkg.entities.registry';
@@ -193,7 +193,7 @@ export interface PackageManager {
   install(
     context: InstallationContext,
     options: PackageManagerInstallOptions
-  ): Promise<{ dependenciesChanged: boolean }>;
+  ): Promise<{ dependenciesChanged: boolean; ignoredBuilds?: IgnoredBuilds }>;
 
   pruneModules?(rootDir: string): Promise<void>;
 

scopes/dependencies/pnpm/lynx.ts

@@ -182,6 +182,14 @@ export interface ReportOptions {
   process?: NodeJS.Process;
 }
 
+export interface InstallResult {
+  dependenciesChanged: boolean;
+  rebuild: RebuildFn;
+  storeDir: string;
+  depsRequiringBuild?: DepPath[];
+  ignoredBuilds?: Set<DepPath>;
+}
+
 export async function install(
   rootDir: string,
   manifestsByPaths: Record<string, ProjectManifest>,
@@ -225,7 +233,7 @@ export async function install(
     Pick<CreateStoreControllerOptions, 'packageImportMethod' | 'pnpmHomeDir' | 'preferOffline'>,
   // eslint-disable-next-line @typescript-eslint/no-unused-vars
   logger?: Logger
-): Promise<{ dependenciesChanged: boolean; rebuild: RebuildFn; storeDir: string; depsRequiringBuild?: DepPath[] }> {
+): Promise<InstallResult> {
   const externalDependencies = new Set<string>();
   const readPackage = createReadPackageHooks(options);
   if (options?.rootComponents && !options?.rootComponentsForCapsules) {
@@ -325,6 +333,7 @@ export async function install(
 
   let dependenciesChanged = false;
   let depsRequiringBuild: DepPath[] | undefined;
+  let ignoredBuilds: Set<DepPath> | undefined;
   if (!options.dryRun) {
     let stopReporting: Function | undefined;
     if (!options.hidePackageManagerOutput) {
@@ -339,6 +348,8 @@ export async function install(
       installsRunning[rootDir] = mutateModules(packagesToBuild, opts);
       const installResult = await installsRunning[rootDir];
       depsRequiringBuild = installResult.depsRequiringBuild?.sort();
+      ignoredBuilds = installResult.ignoredBuilds;
+      console.log(ignoredBuilds)
       if (depsRequiringBuild != null) {
         await addDepsRequiringBuildToLockfile(rootDir, depsRequiringBuild);
       }
@@ -378,6 +389,7 @@ export async function install(
     },
     storeDir: storeController.dir,
     depsRequiringBuild,
+    ignoredBuilds,
   };
 }
 

scopes/dependencies/pnpm/pnpm.package-manager.ts

@@ -49,6 +49,7 @@ export interface InstallResult {
   rebuild: RebuildFn;
   storeDir: string;
   depsRequiringBuild?: DepPath[];
+  ignoredBuilds?: Set<DepPath>;
 }
 
 type ReadConfigResult = Promise<{ config: Config; warnings: string[] }>;
@@ -164,7 +165,7 @@ export class PnpmPackageManager implements PackageManager {
       });
     }
     this.modulesManifestCache.delete(rootDir);
-    const { dependenciesChanged, rebuild, storeDir, depsRequiringBuild } = await install(
+    const { dependenciesChanged, rebuild, storeDir, depsRequiringBuild, ignoredBuilds } = await install(
       rootDir,
       manifests,
       config.storeDir,
@@ -224,7 +225,7 @@ export class PnpmPackageManager implements PackageManager {
       // this.logger.console('-------------------------END PNPM OUTPUT-------------------------');
       // this.logger.consoleSuccess('installing dependencies using pnpm');
     }
-    return { dependenciesChanged, rebuild, storeDir, depsRequiringBuild };
+    return { dependenciesChanged, rebuild, storeDir, depsRequiringBuild, ignoredBuilds };
   }
 
   async getPeerDependencyIssues(

scopes/workspace/install/install.main.runtime.ts

@@ -419,7 +419,7 @@ export class InstallMain {
       // are not added to the manifests.
       // This is an issue when installation is done using root components.
       hasMissingLocalComponents = hasRootComponents && hasComponentsFromWorkspaceInMissingDeps(current);
-      const { dependenciesChanged } = await installer.installComponents(
+      const { dependenciesChanged, ignoredBuilds } = await installer.installComponents(
         this.workspace.path,
         current.manifests,
         mergedRootPolicy,
@@ -431,6 +431,14 @@ export class InstallMain {
         },
         pmInstallOptions
       );
+      if (ignoredBuilds?.size) {
+        const allowScripts = {};
+        for (const ignoredBuild of ignoredBuilds.values()) {
+          allowScripts[ignoredBuild] ??= 'change to true or false';
+        }
+        this.dependencyResolver.updateAllowedScripts(allowScripts);
+        await this.dependencyResolver.persistConfig('update allowScripts configuration');
+      }
       this.workspace.inInstallAfterPmContext = true;
       let cacheCleared = false;
       await this.linkCodemods(compDirMap);