Conversation
# Conflicts: # app/build.gradle.kts # app/src/main/AndroidManifest.xml # app/src/main/kotlin/com/moa/app/main/MainActivity.kt # core/designsystem/build.gradle.kts # core/designsystem/src/main/kotlin/com/moa/app/designsystem/component/core/button/MaButton.kt # core/designsystem/src/main/kotlin/com/moa/app/designsystem/component/core/textfield/MaOtpTextField.kt # core/designsystem/src/main/kotlin/com/moa/app/designsystem/component/product/dialog/MaAlertDialog.kt # core/navigation/src/main/java/com/moa/app/navigation/AppRoute.kt # core/network/src/main/kotlin/com/moa/app/network/adapter/NetworkResultCallAdapter.kt # core/network/src/main/kotlin/com/moa/app/network/adapter/ResponseHandler.kt # core/network/src/main/kotlin/com/moa/app/network/adapter/UnitResponseHandler.kt # core/network/src/test/kotlin/com/moa/app/network/adapter/ResponseHandlerTest.kt # data/src/main/kotlin/com/moa/app/data/quiz/datasource/QuizDataSource.kt # data/src/main/kotlin/com/moa/app/data/quiz/datasourceImpl/QuizDataSourceImpl.kt # data/src/main/kotlin/com/moa/app/data/quiz/model/request/QuizScoreRequest.kt # data/src/main/kotlin/com/moa/app/data/quiz/model/response/AttentionQuizResponse.kt # data/src/main/kotlin/com/moa/app/data/quiz/model/response/LinguisticQuizResponse.kt # data/src/main/kotlin/com/moa/app/data/quiz/model/response/PersistenceQuizResponse.kt # data/src/main/kotlin/com/moa/app/data/quiz/model/response/QuizResponse.kt # data/src/main/kotlin/com/moa/app/data/quiz/model/response/SpaceTimeQuizResponse.kt # data/src/main/kotlin/com/moa/app/data/quiz/repositoryImpl/QuizRepositoryImpl.kt # data/src/main/kotlin/com/moa/app/data/quiz/service/QuizService.kt # data/src/main/kotlin/com/moa/app/data/report/datasource/ReportDataSource.kt # data/src/main/kotlin/com/moa/app/data/report/datasourceImpl/ReportDataSourceImpl.kt # data/src/main/kotlin/com/moa/app/data/report/repositoryImpl/ReportRepositoryImpl.kt # data/src/main/kotlin/com/moa/app/data/report/service/ReportService.kt # data/src/main/kotlin/com/moa/app/data/user/datasource/UserDataSource.kt # data/src/main/kotlin/com/moa/app/data/user/datasourceImpl/UserDataSourceImpl.kt # data/src/main/kotlin/com/moa/app/data/user/model/response/UserProfileResponse.kt # data/src/main/kotlin/com/moa/app/data/user/repositoryImpl/UserRepositoryImpl.kt # data/src/main/kotlin/com/moa/app/data/user/service/UserService.kt # domain/src/main/kotlin/com/moa/app/domain/quiz/model/AttentionQuiz.kt # domain/src/main/kotlin/com/moa/app/domain/quiz/model/LinguisticQuiz.kt # domain/src/main/kotlin/com/moa/app/domain/quiz/model/PersistenceQuiz.kt # domain/src/main/kotlin/com/moa/app/domain/quiz/model/Quiz.kt # domain/src/main/kotlin/com/moa/app/domain/quiz/model/QuizCategory.kt # domain/src/main/kotlin/com/moa/app/domain/quiz/model/QuizScore.kt # domain/src/main/kotlin/com/moa/app/domain/quiz/model/SpaceTimeQuiz.kt # domain/src/main/kotlin/com/moa/app/domain/quiz/repository/QuizRepository.kt # domain/src/main/kotlin/com/moa/app/domain/report/repository/ReportRepository.kt # domain/src/main/kotlin/com/moa/app/domain/report/usecase/FetchDailyReportUseCase.kt # domain/src/main/kotlin/com/moa/app/domain/report/usecase/FetchMonthlyReportUseCase.kt # domain/src/main/kotlin/com/moa/app/domain/report/usecase/FetchWeeklyReportUseCase.kt # domain/src/main/kotlin/com/moa/app/domain/user/repository/UserRepository.kt # feature/guardian/build.gradle.kts # feature/onboarding/src/main/kotlin/com/moa/app/feature/onboarding/connection/UserConnectionScreen.kt # feature/onboarding/src/main/kotlin/com/moa/app/feature/onboarding/connection/UserConnectionViewModel.kt # feature/onboarding/src/main/kotlin/com/moa/app/feature/onboarding/connection/model/UserConnectionUiState.kt # feature/onboarding/src/main/kotlin/com/moa/app/feature/onboarding/role/SelectUserRoleScreen.kt # feature/onboarding/src/main/kotlin/com/moa/app/feature/onboarding/role/SelectUserRoleViewModel.kt # feature/onboarding/src/main/kotlin/com/moa/app/feature/onboarding/signin/SignInScreen.kt # feature/onboarding/src/main/kotlin/com/moa/app/feature/onboarding/signin/SignInViewModel.kt # feature/onboarding/src/main/kotlin/com/moa/app/feature/onboarding/signin/model/SignInUiState.kt # feature/onboarding/src/main/kotlin/com/moa/app/feature/onboarding/signup/SignUpPhoneAuthScreen.kt # feature/onboarding/src/main/kotlin/com/moa/app/feature/onboarding/signup/SignUpProfileScreen.kt # feature/onboarding/src/main/kotlin/com/moa/app/feature/onboarding/signup/SignUpSharedViewModel.kt # feature/onboarding/src/main/kotlin/com/moa/app/feature/onboarding/signup/model/SignUpPhoneAuthUiState.kt # feature/onboarding/src/main/kotlin/com/moa/app/feature/onboarding/splash/SplashViewModel.kt # feature/report/src/main/java/com/moa/app/feature/report/ReportViewModel.kt # feature/senior/build.gradle.kts # feature/senior/src/main/kotlin/com/moa/app/feature/senior/home/SeniorHomeScreen.kt # feature/senior/src/main/kotlin/com/moa/app/feature/senior/home/SeniorHomeViewModel.kt # feature/senior/src/main/kotlin/com/moa/app/feature/senior/quiz/attention/AttentionQuizScreen.kt # feature/senior/src/main/kotlin/com/moa/app/feature/senior/quiz/attention/AttentionQuizViewModel.kt # feature/senior/src/main/kotlin/com/moa/app/feature/senior/quiz/attention/model/AttentionQuizUiState.kt # feature/senior/src/main/kotlin/com/moa/app/feature/senior/quiz/category/QuizCategoryScreen.kt # feature/senior/src/main/kotlin/com/moa/app/feature/senior/quiz/category/QuizCategoryViewModel.kt # feature/senior/src/main/kotlin/com/moa/app/feature/senior/quiz/category/model/QuizCategoryExtension.kt # feature/senior/src/main/kotlin/com/moa/app/feature/senior/quiz/component/QuizCategoryCard.kt # feature/senior/src/main/kotlin/com/moa/app/feature/senior/quiz/component/QuizDescription.kt # feature/senior/src/main/kotlin/com/moa/app/feature/senior/quiz/component/QuizLoadContent.kt # feature/senior/src/main/kotlin/com/moa/app/feature/senior/quiz/component/QuizSlideAnimation.kt # feature/senior/src/main/kotlin/com/moa/app/feature/senior/quiz/linguistic/LinguisticQuizScreen.kt # feature/senior/src/main/kotlin/com/moa/app/feature/senior/quiz/linguistic/LinguisticQuizViewModel.kt # feature/senior/src/main/kotlin/com/moa/app/feature/senior/quiz/linguistic/model/LinguisticQuizUiState.kt # feature/senior/src/main/kotlin/com/moa/app/feature/senior/quiz/persistence/PersistenceQuizScreen.kt # feature/senior/src/main/kotlin/com/moa/app/feature/senior/quiz/persistence/PersistenceQuizViewModel.kt # feature/senior/src/main/kotlin/com/moa/app/feature/senior/quiz/spacetime/SpaceTimeQuizScreen.kt # feature/senior/src/main/kotlin/com/moa/app/feature/senior/quiz/spacetime/SpaceTimeQuizViewModel.kt # feature/senior/src/main/kotlin/com/moa/app/feature/senior/quiz/spacetime/model/SpaceTimeQuizUiState.kt # feature/senior/src/main/kotlin/com/moa/app/feature/senior/setting/SeniorSettingScreen.kt # feature/senior/src/main/kotlin/com/moa/app/feature/senior/setting/SeniorSettingViewModel.kt # feature/senior/src/main/kotlin/com/moa/app/feature/senior/setting/model/SeniorSettingUiState.kt # gradle/libs.versions.toml # settings.gradle.kts
작업 내용 요약이번 변경사항은 시니어 퀴즈 카테고리 UI 모델에 새로운 데이터 클래스 변경 사항
예상 코드 리뷰 난이도🎯 1 (Trivial) | ⏱️ ~5 minutes 관련될 수 있는 PR
축하 시
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
feature/senior/src/main/kotlin/com/moa/app/feature/senior/quiz/category/model/QuizCategoryUiState.kt (1)
5-13: Compose 상태 안정성을 위해ImmutableSet사용을 고려해 보세요.프로젝트에서 이미
kotlinx-collections-immutable라이브러리를 사용하고 있습니다. Compose UI 상태에서Set보다ImmutableSet을 사용하면 불필요한 리컴포지션을 방지할 수 있습니다.♻️ 제안하는 변경
package com.moa.app.feature.senior.quiz.category.model import com.moa.app.domain.quiz.model.QuizCategory +import kotlinx.collections.immutable.ImmutableSet +import kotlinx.collections.immutable.persistentSetOf data class QuizCategoryUiState( - val enabledCategories: Set<QuizCategory> + val enabledCategories: ImmutableSet<QuizCategory> ) { companion object { val INIT = QuizCategoryUiState( - enabledCategories = emptySet() + enabledCategories = persistentSetOf() ) } }
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
feature/guardian/src/main/kotlin/com/moa/app/feature/guardian/.gitkeepfeature/senior/src/main/kotlin/com/moa/app/feature/senior/quiz/category/model/QuizCategoryUiState.ktgradle/libs.versions.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Run Unit Tests
🔇 Additional comments (1)
gradle/libs.versions.toml (1)
8-9: LGTM!1.1.0 릴리즈를 위한 버전 업데이트가 적절합니다.
versionCode가 올바르게 증가되었고,versionName이 시맨틱 버저닝을 따르고 있습니다.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Uncompleted Tasks 😅
Summary by CodeRabbit
주요 변경사항
버전 업데이트
개선사항
✏️ Tip: You can customize this high-level summary in your review settings.