Skip to content

Conversation

@Super-Kenil
Copy link

Updated below dependencies to the latest version

react, react-dom, simple-icons, typescript, @types/react-dom, @types/react

tsdx is at latest

What I did:

  1. created a vite react project for testing right beside example folder
  2. Copied example code from original example to my example2
  3. Checked the example2 with react v17 before updating dependencies
  4. Updated the above mentioned dependencies
  5. Fixed typescript related errors in cloud.ts and use_in_viewport.tsx
  6. Ran yarn test and yarn build successfully
  7. Checked output in example2 and worked successfully just like earlier

@teaguestockwell
Copy link
Owner

I pulled your branch locally and I'm not able to npm install. It seems the versions of tsdx or other dev tooling aren't playing well with react 19.

Teagues-MacBook-Pro:react-icon-cloud teague$ git status
On branch react-19
Your branch is up to date with 'super-kenil/master'.

nothing to commit, working tree clean
Teagues-MacBook-Pro:react-icon-cloud teague$ git branch -v
  fix/icon-cloud-json-structure 3bf9320 Revert "Fix JSON structure handling in get_slug_hex.ts"
  master                        21980cb Bump patch
* react-19                      96db29e Merge pull request #1 from Super-Kenil/bump-react
Teagues-MacBook-Pro:react-icon-cloud teague$ node -v
v22.12.0
Teagues-MacBook-Pro:react-icon-cloud teague$ npm -v
11.0.0
Teagues-MacBook-Pro:react-icon-cloud teague$ npm i
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @testing-library/react@12.1.5
npm error Found: react@19.0.0
npm error node_modules/react
npm error   dev react@"^19.0.0" from the root project
npm error   peer react@"^19.0.0" from react-dom@19.0.0
npm error   node_modules/react-dom
npm error     dev react-dom@"^19.0.0" from the root project
npm error
npm error Could not resolve dependency:
npm error peer react@"<18.0.0" from @testing-library/react@12.1.5
npm error node_modules/@testing-library/react
npm error   dev @testing-library/react@"^12.0.0" from the root project
npm error
npm error Conflicting peer dependency: react@17.0.2
npm error node_modules/react
npm error   peer react@"<18.0.0" from @testing-library/react@12.1.5
npm error   node_modules/@testing-library/react
npm error     dev @testing-library/react@"^12.0.0" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /Users/teague/.npm/_logs/2024-12-29T19_32_17_636Z-eresolve-report.txt
npm error A complete log of this run can be found in: /Users/teague/.npm/_logs/2024-12-29T19_32_17_636Z-debug-0.log
Teagues-MacBook-Pro:react-icon-cloud teague$ 

@Super-Kenil
Copy link
Author

@teaguestockwell please check now, it should be fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants