[sync] fix(t5079): remove unnecessary permissions decorator from testTransportConfig method#3321
[sync] fix(t5079): remove unnecessary permissions decorator from testTransportConfig method#3321tea-artist wants to merge 1 commit into
Conversation
…TransportConfig method Synced from teableio/teable-ee@e00341c Co-authored-by: Aries X <caoxing9@gmail.com> Co-authored-by: Boris <boris2code@outlook.com> Co-authored-by: Jun Lu <hammond@teable.io> Co-authored-by: Pengap <penganpingprivte@gmail.com> Co-authored-by: SkyHuang <sky.huang.fe@gmail.com> Co-authored-by: Uno <uno@teable.ai> Co-authored-by: nichenqin <nichenqin@hotmail.com>
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8b83b5d14b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| WHERE t.typname = 'SpaceDataDbMigrationJobState' | ||
| AND e.enumlabel = 'waiting_worker' | ||
| ) THEN | ||
| ALTER TYPE "SpaceDataDbMigrationJobState" ADD VALUE 'waiting_worker' AFTER 'pending'; |
There was a problem hiding this comment.
Include waiting_worker in active migration uniqueness
Adding the waiting_worker state makes new migrations start in that state (startMigrationForSpace creates jobs with state: 'waiting_worker'), but the existing partial unique index space_data_db_migration_job_active_space_id_key still only covers pending/preflight/freezing_writes/copying/validating/switching. Under concurrent start requests for the same space, both requests can pass the application-level active-job check and insert waiting_worker rows because the database no longer enforces uniqueness for the actual initial active state; later workers can then run duplicate migrations for one space. This migration should also rebuild/update the partial unique index to include waiting_worker.
Useful? React with 👍 / 👎.
🔄 Automated sync from EE repository.
88 commit(s) synced since last sync.
Authors
Included commits
Latest source commit: teableio/teable-ee@e00341c
This PR was automatically created by the sync workflow.