Skip to content

feat: multi-line field names & batch collapse by group #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

Sky-FE
Copy link
Contributor

@Sky-FE Sky-FE commented May 5, 2025

No description provided.

@Sky-FE Sky-FE added the preview This issue is already ready for preview label May 5, 2025
@Sky-FE Sky-FE requested a review from Copilot May 5, 2025 03:03
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This feature PR introduces support for multi-line field names and batch collapse of group headers. Key changes include updates to GridView components and toolbar handlers to support a new fieldNameDisplayLines option, the addition of a new constant for field name height definitions, and backend updates to return additional group header references.

Reviewed Changes

Copilot reviewed 42 out of 51 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
apps/nextjs-app/src/features/app/blocks/view/tool-bar/components/GridViewOperators.tsx Updated import and callback handlers to support fieldNameDisplayLines.
apps/nextjs-app/src/features/app/blocks/view/hooks/useToolbarChange.ts Added onFieldNameDisplayLinesChange to update view options.
apps/nextjs-app/src/features/app/blocks/view/grid/const.ts Added GIRD_FIELD_NAME_HEIGHT_DEFINITIONS constant.
apps/nextjs-app/src/features/app/blocks/view/grid/components/GroupHeaderMenu.tsx Introduced new GroupHeaderMenu component for group collapse/expand.
apps/nextjs-app/src/features/app/blocks/view/grid/GridViewBaseInner.tsx Integrated new height definitions and added onGroupHeaderContextMenu.
apps/nextjs-app/src/features/app/blocks/view/grid/DomBox.tsx Included GroupHeaderMenu in the DOM box component.
apps/nextjs-app/src/features/app/blocks/share/view/component/grid/toolbar/Toolbar.tsx Enhanced toolbar to handle fieldNameDisplayLines.
apps/nextjs-app/src/features/app/blocks/share/view/component/grid/GridViewBase.tsx Updated grid view to use new options and added onColumnFreeze and onGroupHeaderContextMenu.
apps/nestjs-backend/test/aggregation.e2e-spec.ts Added tests for group header references behavior.
apps/nestjs-backend/src/features/record/record.service.ts Modified RecordService to include allGroupHeaderRefs in responses.
Files not reviewed (9)
  • packages/common-i18n/src/locales/de/sdk.json: Language not supported
  • packages/common-i18n/src/locales/de/table.json: Language not supported
  • packages/common-i18n/src/locales/en/sdk.json: Language not supported
  • packages/common-i18n/src/locales/en/table.json: Language not supported
  • packages/common-i18n/src/locales/es/sdk.json: Language not supported
  • packages/common-i18n/src/locales/es/table.json: Language not supported
  • packages/common-i18n/src/locales/fr/sdk.json: Language not supported
  • packages/common-i18n/src/locales/fr/table.json: Language not supported
  • packages/common-i18n/src/locales/it/sdk.json: Language not supported
Comments suppressed due to low confidence (1)

apps/nextjs-app/src/features/app/blocks/view/grid/const.ts:11

  • [nitpick] The constant name 'GIRD_FIELD_NAME_HEIGHT_DEFINITIONS' may be a typo. For clarity and consistency, consider renaming it to 'GRID_FIELD_NAME_HEIGHT_DEFINITIONS' if appropriate.
export const GIRD_FIELD_NAME_HEIGHT_DEFINITIONS = [0, 32, 56, 80];

@coveralls
Copy link
Collaborator

coveralls commented May 5, 2025

Pull Request Test Coverage Report for Build 14828572373

Details

  • 22 of 23 (95.65%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.001%) to 80.511%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nestjs-backend/src/features/record/record.service.ts 22 23 95.65%
Files with Coverage Reduction New Missed Lines %
apps/nestjs-backend/src/features/base/BatchProcessor.class.ts 2 68.29%
apps/nestjs-backend/src/features/base/base-import-processor/base-import-csv.processor.ts 3 65.35%
Totals Coverage Status
Change from base Build 14767810367: -0.001%
Covered Lines: 36829
Relevant Lines: 45744

💛 - Coveralls

Copy link

github-actions bot commented May 5, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-1504.sealoshzh.site

Copy link

github-actions bot commented May 5, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-1504.sealoshzh.site

@Sky-FE Sky-FE requested a review from tea-artist May 5, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview This issue is already ready for preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants