double-encoding of json response results in `TypeError: string indices must be integers, not 'str'`

[cjw296]

This looks like a change in Tesla API responses over the last couple of weeks as this has been working fine for a year or two now without change on my end...

My code does:

battery.set_tariff(required_tariff)

This results in a POST to https://owner-api.teslamotors.com/api/1/energy_sites/2444871/time_of_use_settings, but what comes back nows is:

'{"response":"{\\"Message\\":\\"Updated\\",\\"Code\\":201}\\n"}'

Note the response is now a string containing json, so it would need to be decoded again, but in the meantime this happens:

    self.battery.set_tariff(required_tariff)
  File "/python3.12/site-packages/teslapy/__init__.py", line 869, in set_tariff
    return self.command('TIME_OF_USE_SETTINGS',
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/.venv/lib/python3.12/site-packages/teslapy/__init__.py", line 804, in command
    if response['code'] == 201:
       ~~~~~~~~^^^^^^^^
TypeError: string indices must be integers, not 'str'

Anyone else seen this?

[cjw296]

Workaround:

from teslapy import Product, ProductError

def patched_command(self, name, **kwargs):
    response = self.api(name, **kwargs)['response']
    # https://github.com/tdorssers/TeslaPy/issues/174
    if isinstance(response, str):
        response = json.loads(response)
    if (response.get('code') or response.get('Code')) == 201:
        return response.get('message')
    raise ProductError(response.get('message'))

Product.command = patched_command