Skip to content

Remove CRLF from folded HTTP header values #3654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
giorka wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove CRLF from folded HTTP header values #3654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion tdnet/td/net/HttpReader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,31 @@ Result<size_t> HttpReader::split_header() {

void HttpReader::process_header(MutableSlice header_name, MutableSlice header_value) {
header_name = trim(header_name);
header_value = trim(header_value); // TODO need to remove "\r\n" from value
header_value = trim(header_value);

auto *data = header_value.data();
size_t write_pos = 0;
for (size_t read_pos = 0; read_pos < header_value.size();) {
if (header_value[read_pos] == '\r' && read_pos + 1 < header_value.size() &&
header_value[read_pos + 1] == '\n') {
read_pos += 2;

while (read_pos < header_value.size() &&
(header_value[read_pos] == ' ' || header_value[read_pos] == '\t')) {
read_pos++;
}

if (write_pos != 0 && read_pos < header_value.size()) {
data[write_pos++] = ' ';
}
continue;
}

data[write_pos++] = header_value[read_pos++];
}

header_value = trim(MutableSlice(data, write_pos));

to_lower_inplace(header_name);
LOG(DEBUG) << "Process header [" << header_name << "=>" << header_value << "]";
query_->headers_.emplace_back(header_name, header_value);
Expand Down