Repository navigation
add e2e test broadcasting a pegin transaction - #5
Merged
Merged
Conversation
Contributor
|
Please open an issue for this, we will add this possibility to identity in ldk |
astral-horizon-labs
approved these changes
Jun 14, 2021
tiero
reviewed
Jun 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an e2e test for
claimTxmethod, broadcasting a pegin transaction on a nigiri regtest network.Note about LDK Mnemonic: the current test uses
PrivateKeyidentity, so I'm able to sign the transaction with the right privateKey (usingliquidjs.ECPair). However, theMnemonicIdentity doesn't let to get the private key for a specific derivation path. So we need to regenerate the key pair for a given address in order to sign the pegin transaction. I do think that we should implement a "Pegin signer" interface in LDK in order to make the process easier for developers. @tiero what's your opinion?@tiero @altafan @Janaka-Steph please review