Open
Conversation
Owner
|
Hi Marcus, Sorry for the really delayed reply (I flagged the email for follow up and then never got around to it). That change should be fine. I note that you have removed the sign function I had defined in the module but it is still used in the return statement of the solve function. I haven't tested out your code directly, does it still work ok? Cheers, Tom |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can we add an optional, default-False param to return the basis? I'd need this feature for a project.
Also I'd suggest using int(sympy.sign) instead of redefining sign. If you don't like it, only merge the first commit.