Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: IndexOutOfBoundsException thrown in topics view when changing to… #962

Merged
merged 4 commits into from
Dec 22, 2021

Conversation

EdwinFajardoBarrera
Copy link
Contributor

… cluster with fewer pages.

Closes issue #835

When the cluster is changed now it forces the state to have pageNumber equals to 1 to avoid failure if the new cluster has fewer pages than the old one.

@EdwinFajardoBarrera
Copy link
Contributor Author

@tchiotludo If you can review my PR I would appreciate it, I await your comments, greetings!

@tchiotludo
Copy link
Owner

@EdwinFajardoBarrera it seems to be a good fix !
Is it possible to handle this on list please ?

@EdwinFajardoBarrera
Copy link
Contributor Author

@EdwinFajardoBarrera it seems to be a good fix ! Is it possible to handle this on list please ?

Sorry I don't get you, how can I help you?

@tchiotludo
Copy link
Owner

For example this one, I've the feeling the bug is also here ?
May you have a look on all pages with pagination ?

@EdwinFajardoBarrera
Copy link
Contributor Author

For sure, take it for granted

@EdwinFajardoBarrera
Copy link
Contributor Author

EdwinFajardoBarrera commented Dec 22, 2021

@tchiotludo I'm having issues configuring multiple clusters, actually, this is working

  • Kafka-0
  • Schema-registry-0
  • Connector-0 Docker container stops
  • Kafka-1
  • Schema-registry-1
  • Connector-1

I leave my docker-compose-multiple-cluster.yml file: https://codeshare.io/1YbNvX

My application-dev.yml connections are as follows:

akhq:
  connections:
    local-0:
      properties:
        bootstrap.servers: "localhost:9092"
      schema-registry:
        url: "http://localhost:8085"
      connect:
      - name: "connect-0"
        url: "http://localhost:8083"
    local-1:
      properties:
        bootstrap.servers: "localhost:9072"
      schema-registry:
        url: "http://localhost:8075"
      connect:
      - name: "connect-1"
        url: "http://localhost:8084"

Thanks for your help

@tchiotludo
Copy link
Owner

can you give the log of the failed connect please ?
I don't see any reasoon like that

@EdwinFajardoBarrera
Copy link
Contributor Author

can you give the log of the failed connect please ? I don't see any reasoon like that

I just got this:

image

image

I see that the first connect instance that I select makes the other shutdown.

[2021-12-22 19:16:37,849] INFO [Worker clientId=connect-1, groupId=kafka-connect-1] Session key updated (org.apache.kafka.connect.runtime.distributed.DistributedHerder)

Dec 22, 2021 7:16:35 PM org.glassfish.jersey.internal.inject.Providers checkProviderRuntime

WARNING: A provider org.apache.kafka.connect.runtime.rest.resources.RootResource registered in SERVER runtime does not implement any provider interfaces applicable in the SERVER runtime. Due to constraint configuration problems the provider org.apache.kafka.connect.runtime.rest.resources.RootResource will be ignored.

@tchiotludo
Copy link
Owner

You have a mistake corrected here : https://codeshare.io/1YbNvX
But I'm not really sure you're setup is possible like that (on the same docker host / multiple kafka, zookepper), I've the feeling they will try to make a unique cluster

@EdwinFajardoBarrera
Copy link
Contributor Author

For example this one, I've the feeling the bug is also here ? May you have a look on all pages with pagination ?

I just checked and fixed this and apparently, there is no other page (where using pagination) that replicates this bug.

@tchiotludo tchiotludo merged commit 9f526fd into tchiotludo:dev Dec 22, 2021
@tchiotludo
Copy link
Owner

THanks for having a deeper look 👍

@EdwinFajardoBarrera
Copy link
Contributor Author

THanks for having a deeper look 👍

No problem, let me know if there is another issue with priority (If this is in the backend is better for me)

@tchiotludo
Copy link
Owner

backend Need a backend update you will find the backend issue, feel free to pick up one that sound interesting for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants