fix(ui): broken error handling for all api requests #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handleError is not inside a component and so hooks can't be used. React-router suggests useing the redirect function instead of useNavigate but this only works if it's inside a loader/action which I don't think we necessarily are.
AlexisSouquiere
approved these changes
Jun 5, 2024
|
Well done ! I tested the fix, I confirm that errors are correctly shown now. Thanks 🚀 |
AlexisSouquiere
changed the title
|
@AlexisSouquiere Given that this affects every failed api request for everyone on 0.25 do you think we can get a new version for this? |
|
I think @tchiotludo agreed in another discussion that we should release more often now. So I assume that after merging this PR and maybe checking few other issues there is in the backlog we will release a patch version |
|
Sounds good, thanks @AlexisSouquiere 🍺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1807
This is currently affecting all error handling for failed api requests
handleError is not inside a component and so hooks can't be used.
React-router suggests using the redirect function instead of useNavigate but this only works if it's inside a loader/action which I don't think we necessarily are.
Tested and this works, normal error handling shows a toast and if I get a 401/403 im redirected to the login page and i still see a toast with the error message 👍