Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): set default value correctly for github api (#1775) #1779

Merged
merged 1 commit into from
May 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/docs/configuration/authentifications/github.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@ micronaut:
auth-method: client-secret-post
```

You can also override the GitHub API url if needed. Default value is https://api.github.com

```yaml
github.api.url: https://override.api.github.com
```

To further tell AKHQ to display GitHub SSO options on the login page and customize claim mapping, configure Oauth in the AKHQ config:

```yaml
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

@Header(name = "User-Agent", value = "Micronaut")
@Header(name = "Accept", value = "application/vnd.github.v3+json, application/json")
@Client("${github.api.url}")
@Client("${github.api.url:`https://api.github.com`}")
public interface GithubApiClient {

@Get("/user")
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/application.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ micronaut:
http:
client:
allow-block-event-loop: true
github.api.url: https://api.github.com


jackson:
serialization:
Expand Down
Loading