Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove @JsonIgnore for topic field in Record.java #1672

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

arindampatra33
Copy link
Contributor

@arindampatra33 arindampatra33 commented Feb 16, 2024

remove @JsonIgnore for topic field in Record.java . This is required to fix the tail functionality.
@tchiotludo , PR 1628 added this to not include topic info in the downloaded data but this breaks the tail functionality which we use almost on a daily basis (and yes we use dev version in our lower env)

The ui goes blank when there's an incoming record in the topic we are tailing and this error can be seen from inspect element

Tail.jsx:112 TypeError: Cannot read properties of undefined (reading 'name')
    at rowId (Tail.jsx:398:33)
    at Table.jsx:519:17
    at Array.forEach (<anonymous>)
    at o.value (Table.jsx:517:10)
    at Wa (react-dom.production.min.js:182:192)
    at Ba (react-dom.production.min.js:181:224)
    at Ss (react-dom.production.min.js:263:490)
    at vc (react-dom.production.min.js:246:265)
    at mc (react-dom.production.min.js:246:194)
    at sc (react-dom.production.min.js:239:172)

Could you review/merge this asap

remove @JsonIgnore for topic . This is required to fix the tail functionality
@tchiotludo tchiotludo merged commit 536264f into tchiotludo:dev Feb 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants