fix(RecordRepository): fix copy infinite loop when record added durin… #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchiotludo
force-pushed
the
feat/fix-copy-dlt-to-main
branch
from
5451c82
to
31159bd
Compare
tchiotludo
requested changes
Nov 19, 2023
There was a problem hiding this comment.
@valTroadec some test are failing, can you fixed them please?
valTroadec
force-pushed
the
feat/fix-copy-dlt-to-main
branch
from
31159bd
to
9adfafd
Compare
|
@tchiotludo I did not see the effects of creating new topics in tests at first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1377
Hey,
Fix for the infinite loop in the case records are copied to an other topic and an other record has been queued.
I filter them with the last offset we got in the start state.
Can be reproduced easily.