fix(ui): clicking on Empty Topic button display blank screen (#1429)

close #912 Co-authored-by: Olivier <oghizzo@xebia.fr>
tchiotludo · Mar 18, 2023 · 1f85d80 · 1f85d80
1 parent a773a4b
commit 1f85d80
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/client/src/containers/Topic/Topic/Topic.jsx b/client/src/containers/Topic/Topic/Topic.jsx
@@ -84,8 +84,7 @@ class Topic extends Root {
   canEmptyTopic = () => {
     const { configs } = this.state;
     const res = configs.filter(config => config.name === 'cleanup.policy');
-    if (res && res.length === 1 && res[0].value.includes('delete')) return true;
-    return false;
+    return res && res.length === 1 && res[0].value.includes('delete');
   };
 
   emptyTopic = () => {
@@ -95,7 +94,7 @@ class Topic extends Root {
       .then(() => {
         toast.success(`Topic '${topicId}' will be emptied`);
         this.setState({ showDeleteModal: false }, () => {
-          this.topicData.current.getMessages();
+          this.topicData.current._getMessages(false);
         });
       })
       .catch(() => {

diff --git a/client/src/containers/Topic/Topic/TopicData/TopicData.jsx b/client/src/containers/Topic/Topic/TopicData/TopicData.jsx
@@ -297,7 +297,7 @@ class TopicData extends Root {
     this._fetchMessages(requests);
   }
 
-  _getMessages(changePage = false) {
+  _getMessages = changePage => {
     const { selectedCluster, selectedTopic, nextPage } = this.state;
 
     const filters = this._buildFilters();
@@ -315,7 +315,7 @@ class TopicData extends Root {
     } else {
       this._setUrlHistory(filters);
     }
-  }
+  };
 
   _fetchMessages(requests, changePage = false) {
     const { nextPage, pageNumber, partitionCount, recordCount, offsets } = this.state;