Skip to content

Commit

Permalink
CI: Pin dependencies for MSRV build ... properly
Browse files Browse the repository at this point in the history
Commit `0e0dcb7f CI: Pin dependencies required for MSRV build` is
totally wrong, why did it get through CI?

In the CI script do:

- `serde_json` is not a dependency of `secp256k1`, remove the pinning
- Put the pinning _before_ any call to `cargo`
- Pin the transient dependency `wasm-bindgen-test`
  • Loading branch information
tcharding committed Jul 14, 2023
1 parent 8e48e15 commit e6643c0
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions contrib/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,18 @@ if cargo --version | grep nightly; then
NIGHTLY=true
fi

# Pin dependencies as required if we are using MSRV toolchain.
if cargo --version | grep "1\.48"; then
cargo update -p wasm-bindgen-test --precise 0.3.34
cargo update -p serde --precise 1.0.156
fi

# Test if panic in C code aborts the process (either with a real panic or with SIGILL)
cargo test -- --ignored --exact 'tests::test_panic_raw_ctx_should_terminate_abnormally' 2>&1 | tee /dev/stderr | grep "SIGILL\\|panicked at '\[libsecp256k1\]"

# Make all cargo invocations verbose
export CARGO_TERM_VERBOSE=true

# Pin dependencies as required if we are using MSRV toolchain.
if cargo --version | grep "1\.48"; then
# 1.0.157 uses syn 2.0 which requires edition 2021
cargo update -p serde_json --precise 1.0.99
cargo update -p serde --precise 1.0.156
fi

# Defaults / sanity checks
cargo build --all
cargo test --all
Expand Down

0 comments on commit e6643c0

Please sign in to comment.