Add japan exclusive stamp promo #969
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, first PR, do not hesitate to tell me if something is wrong :) Link to the card image https://www.pokemon-card.com/assets/images/card_images/large/S-P/039954_P_PIKACHUU.jpg
Member
🃏 2 Cards ChangedDetails: 2 new ➕ New card: 230.tsFile: data-asia/S/S-P/230.ts ➕ New card: 231.tsFile: data-asia/S/S-P/231.ts |
Aviortheking
requested changes
Nov 13, 2025
Member
Aviortheking
left a comment
Aviortheking
left a comment
There was a problem hiding this comment.
Hi, thanks for your contributions !
Just one thing, the cards are 226 & 227 while you named them 230 & 231.
Can you change the files & it should be OK after that !
Author
Member
|
Yes, the card localID is defined by the filename, if it is already defined it means cards are present in other languages |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add two cards:
Details
Hello, this is my first PR, tell me if there is something wrong.
Do I need to also edit S-P.ts?