fix: Add serie field to SetResume in setToSetSimple function #1071
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The GraphQL API was failing with the error:
This was happening because the
setToSetSimplefunction inserver/compiler/utils/setUtil.tswas not including theseriefield in the returnedSetResumeobject.The GraphQL schema defines
Set.serieas non-nullable (serie: Serie!), but cards were being compiled with set objects that had noseriefield, causing GraphQL queries to fail.Solution
Added the
seriefield to theSetResumeobject returned bysetToSetSimple:This matches the structure used in
setToSetSingleand ensures all card objects have the requiredseriereference in their set objects.Testing
set.seriefield populatedRelated Issues
This fixes the test failures in PR #1049 and any other PRs that were encountering the "Cannot return null for non-nullable field Set.serie" error.