forked from project-chip/connectedhomeip
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add new AddStatus overloads using ClusterStatusCode (project-chip#33904)
* Add new AddStatus overloads using ClusterStatusCode - CommandHandler and WriteHandler did not have a way to cleanly just `AddStatus` with a cluster-specific status code (to eventually harmonize handling methods to always return just a ClusterStatusCode). This PR: - Introduces an `AddStatus` overload for `ClusterStatusCode` to CommandHandler and WriteHandler. - Removes the unimplemented `WriteClient::Shutdown` method. - Adds notes to the `AddClusterSpecificSuccess` and `AddClusterSpecificFailure`. - Removes implicit conversion from `ClusterStatusCode` to `Status` - Was never used and was error-prone/lossy Fixes project-chip#31120 Testing done: - Updated necessary unit tests. - Added unit tests for cluster specific statuses on writes. - Integration tests still pass. * Restyled by clang-format * Improve type safety of test * Address review comments - Make StatusIB initializable from ClusterStatusCode - Clean-ups requested - CommandResponseHelper loses the error-prone cluster-specific-code on success (can be added back if ever needed). * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
- Loading branch information
1 parent
6842912
commit ad344f5
Showing
14 changed files
with
320 additions
and
100 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.