jsonrpclib: Fix TransportMixin implementation. #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The send_request implementation in TransportMixin erroneously sent the request body (it is only supposed to send the "POST" line and headers). This is not a problem with py2.7, because there the XMLTransport class from xmlrpclib invokes single_request, which is implemented in jsonrpclib and expects this wrong behavior. The py2.6 xmlrpc lib instead invokes send_request, emits some more headers and then invokes sent content. As the bad send_request already sent the content, the attempt to add more headers afterwards failed. This patch removes the send_content call from send_request and adds it in single_request instead.
|
The behaviour doesn't change on Py2.7/3+, so the pull request is accepted. |
tcalmant
added a commit
that referenced
this pull request
Jan 29, 2016
jsonrpclib: Fix TransportMixin implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The send_request implementation in TransportMixin erroneously sent the
request body (it is only supposed to send the "POST" line and
headers). This is not a problem with py2.7, because there the
XMLTransport class from xmlrpclib invokes single_request, which is
implemented in jsonrpclib and expects this wrong behavior. The py2.6
xmlrpc lib instead invokes send_request, emits some more headers and
then invokes sent content. As the bad send_request already sent the
content, the attempt to add more headers afterwards failed.
This patch removes the send_content call from send_request and adds it
in single_request instead.