add error stack accessor tests#5045
Merged
Merged
Conversation
42 tasks
gibson042
approved these changes
May 21, 2026
gibson042
left a comment
gibson042
left a comment
Member
There was a problem hiding this comment.
This is good (and very thorough), but I'd like to see the files refactored for better accessibility (e.g., my review time could have been cut in half if there were fewer files that pretty much only differ in features).
Comment on lines
+21
to
+29
| var nativeErrors = [ | ||
| Error, | ||
| EvalError, | ||
| RangeError, | ||
| ReferenceError, | ||
| SyntaxError, | ||
| TypeError, | ||
| URIError | ||
| ]; |
Member
There was a problem hiding this comment.
I'm surprised not to see this already defined in a harness file; consider adding it.
Address review feedback on #5045: - prop-desc.js now uses verifyPrimordialAccessorProperty, subsuming the separate getter-/setter-length.js and getter-/setter-name.js files. - Merge the per-type no-error-data files (ArrayBuffer, Map, Set, WeakMap, WeakSet, Promise, TypedArray) and getter-null-proto-receiver into getter-no-error-data.js using dynamic filtering. - Merge getter-this-not-object-{bigint,symbol}.js into getter-this-not-object.js; same for the setter and for setter-non-string-value. - Merge getter-aggregate-error.js, getter-suppressed-error.js, and their *-prototype counterparts into getter-error-instance.js and getter-error-prototype.js with dynamic filtering. Same shape on the setter side via setter-creates-own-property.js and setter-receiver-is-other-prototype.js. - Use allowProxyTraps (proxyTrapsHelper.js) for the proxy receiver tests so unrelated traps fail loudly. - Rename {getter,setter}-null-proto-receiver.js to {getter,setter}-receiver-is-null-proto.js and {getter,setter}-proxy-receiver.js to {getter,setter}-receiver-is-proxy.js.
A test that wires several proxies through allowProxyTraps has no way to distinguish which one triggered an unexpected trap call. Add an optional second-positional label argument; when present it is prefixed onto each Test262Error message. Backward compatible: existing callers pass at most one argument and continue to receive unprefixed messages.
ljharb
force-pushed
the
error-stack-accessor
branch
from
786fb8b to
26218d2
Compare
gibson042
approved these changes
May 21, 2026
Member
Author
|
all done. i'll merge this, and i'll happily make any further changes in a followup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See tc39/proposal-error-stack-accessor#9