Update tests for Reflect.enumerate and Proxy enumerate trap #496
Conversation
leobalter
force-pushed
the
495-enumerate
branch
2 times, most recently
from
84fb140
to
9a841eb
Compare
|
rebased after conflicts with master. |
|
just a heads up to say tc39/ecma262#367 is already merged and this is ready for a review. This PR also told it's better to wait until the reference is done/completed before opening a PR. |
| assert.sameValue(next.done, true); | ||
| next = itor.next(); | ||
| assert.sameValue(next.value, undefined); | ||
| assert.sameValue(next.done, true); |
There was a problem hiding this comment.
All next.dones except the last one should be false.
|
@leobalter Everything LGTM except the one comment I left inline. |
leobalter
force-pushed
the
495-enumerate
branch
from
c7d50b4
to
81fde2f
Compare
|
It's done and rebased, thanks! |
| forInResults.push(x); | ||
| } | ||
|
|
||
| assert(compareArray(forInResults, [0, 1, 2])); |
There was a problem hiding this comment.
Array items should be string instead of number.
|
I am sorry for this. Such small PR and it comes with such typo chaos. I feel bad about this and I'm taking actions to avoid problems like this in the future. |
leobalter
force-pushed
the
495-enumerate
branch
from
81fde2f
to
b1ac539
Compare
|
fixed |
| @@ -0,0 +1,48 @@ | |||
| /* global assert */ | |||
There was a problem hiding this comment.
@leobalter I don't think we need this, do we?
There was a problem hiding this comment.
I'm trying Visual Studio Code :)
I need to turn off the auto linting setting
There was a problem hiding this comment.
fixed. I can't say it's linted. :)
No worries 😄 |
leobalter
force-pushed
the
495-enumerate
branch
from
b1ac539
to
1809059
Compare
leobalter
force-pushed
the
495-enumerate
branch
from
1809059
to
efced6e
Compare
Update tests for Reflect.enumerate and Proxy enumerate trap
Closes #495
Depends on tc39/ecma262#367