Intl Era Monthcode: Tests for M13 intercalary month in coptic, ethioaa, ethopic calendars #4707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds tests for addition and subtraction on leap day (M13-06) and constraining to M13-05 in common years for the three Orthodox calendars (coptic, ethioaa, ethiopic).
Similar to the previous commit, this adds tests for adjusting the year number using the with() method on leap day (M13-06) and constraining to M13-05 in common years for the three Orthodox calendars (coptic, ethioaa, ethiopic).
This adds tests for constraining the day when adding months in the three Orthodox calendars (coptic, ethioaa, ethiopic). Adding years is already covered in the leap-year-*.js tests. The only time that the days need to be constrained to the end of the month is in the epagomenal month (M13), since all the other months always have 30 days.
This adds tests for constraining the day when changing the month code using the with() method in the three Orthodox calendars (coptic, ethioaa, ethiopic). Adding years is already covered in the leap-year-*.js tests. The only time that the days need to be constrained to the end of the month is in the epagomenal month (M13), since all the other months always have 30 days.
…lendars This adds tests for computing the difference between two dates in the three Orthodox calendars (coptic, ethioaa, ethiopic) specifically in and across the epagomenal month (M13).
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for arithmetic involving the M13 intercalary month in the
coptic,ethioaa, andethiopiccalendars. The three calendars have the same structure, just different eras and year numbering, so the tests are very similar between the three calendars. As usual, the PlainDateTime and ZonedDateTime tests are similar to the PlainDate ones;add()tests are similar tosubtract()ones; andsince()tests are similar tountil()ones.For reviewing, I recommend picking one calendar, and reading the
PlainDate/prototype/{add,until,with}folders carefully, and just spot-checking the rest.