Skip to content

Conversation

@jugglinmike
Copy link
Contributor

For every pull request, verify that the WEB_FEATURES.yml file is internally consistent and that the pull request does not reduce the number of tests associated with a given classifier.

Failing for any reduction in the number of matched tests is intended to alert contributors during file renaming operations. This failure will need to be ignored when tests are simply deleted, and this could potentially become a distraction for maintainers. However, test deletion has historically been so rare that spurious failures are not expected to be common enough to substantively interfere with routine maintenance.

@jugglinmike jugglinmike requested a review from a team as a code owner November 22, 2025 05:22
@jugglinmike jugglinmike force-pushed the lint-web-features branch 2 times, most recently from 9f5274b to aa74a3b Compare November 22, 2025 06:17
For every pull request, verify that the `WEB_FEATURES.yml` file is
internally consistent and that the pull request does not reduce the
number of tests associated with a given classifier.

Failing for any reduction in the number of matched tests is intended to
alert contributors during file renaming operations. This failure will
need to be ignored when tests are simply deleted, and this could
potentially become a distraction for maintainers. However, test deletion
has historically been so rare that spurious failures are not expected to
be common enough to substantively interfere with routine maintenance.
@ptomato
Copy link
Contributor

ptomato commented Nov 24, 2025

However, test deletion has historically been so rare that spurious failures are not expected to be common enough to substantively interfere with routine maintenance.

I think the main place where this would come up is when moving tests out of staging, into the main tree. They might get merged into existing tests. I don't actually know if the classification applies to the staging folder in the first place, so maybe this isn't a problem.

@jugglinmike
Copy link
Contributor Author

I think the main place where this would come up is when moving tests out of staging, into the main tree. They might get merged into existing tests. I don't actually know if the classification applies to the staging folder in the first place, so maybe this isn't a problem.

That's a good call-out! We haven't classified tests in staging, so fortunately those kinds of moves won't be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants