Intl Era Monthcode: Tests for constrain end-of-month days in tabular Hijri calendars #4700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests for year and month arithmetic around constraining the day to the end of a 29 or 30 day month in leap and common years, in the islamic-civil calendar, for add(), subtract(), and with(). (This is a tabular calendar, so leap and common years follow a mathematical pattern. Odd months have 30 days and even months have 29, except the last month which has 30 days in leap years.)
Tests for year and month arithmetic around constraining the day to the end of a 29 or 30 day month in leap and common years, in the islamic-tbla calendar, for add(), subtract(), and with(). (This is a tabular calendar. Leap years and month lengths are the same as in the islamic-civil calendar in the previous commit. The epoch day is different which doesn't make a difference to the result of these tests, so they are nearly identical to the islamic-civil tests in the previous commit.)
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Nov 24, 2025
Similar to tc39#4700 but this is for an observational Hijri calendar, not a tabular one. Any month may have either 29 or 30 days in any year. So we additionally test adding or subtracting 1 year from day 30 of a month, and landing in a year where that month has 29 days. Observational month lengths are provided in a comment for convenience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for constraining end-of-month days when adding/changing months and years in the two tabular Hijri calendars (
islamic-civilandislamic-tbla). Expands the existing tests that were already here.As usual, I recommend reviewing the tests in
PlainDate/prototype/addand/withcarefully, and spot-checking the others which are very similar.