Intl Era Monthcode: Constraining to end-of-month days, ISO-like calendars #4699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
force-pushed
the
constrain-day-iso-like
branch
from
3928722 to
dee9ce9
Compare
This adds tests similar to the ISO8601 calendar ones in test/built-ins/ for constraining the day to the end of the month when adding a number of months, for the four ISO8601-like calendars (buddhist, gregory, japanese, roc).
Similar to the previous commit, this adds tests for constraining the day to the end of the month, but using the with() method. For the four ISO8601-like calendars (buddhist, gregory, japanese, roc).
ptomato
force-pushed
the
constrain-day-iso-like
branch
from
dee9ce9 to
bf94cce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests similar to the ISO8601 calendar ones in test/built-ins/ for constraining the day to the end of the month when adding a number of months, for the four ISO8601-like calendars (buddhist, gregory, japanese, roc).
As usual, I recommend reviewing only the
PlainDate/prototype/addandPlainDate/prototype/withones, the others are very similar.