Intl.Era-monthcode: tests to ensure weekofYear only set when using "iso8601" calendar
#4632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
ptomato
requested changes
Nov 4, 2025
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
A couple of things with these tests:
- They need to test
yearOfWeekas well asweekOfYear - ISO8601 calendar giving week numbers needs to be tested in the non-Intl-only section (but in fact already is, so you can just drop that part)
- I think it'd be good to move these into
test/intl402/Temporal/{PlainDate,PlainDateTime,ZonedDateTime}/prototype/{weekOfYear,yearOfWeek}/non-iso-week-of-year.jswhich already tests this but in an incomplete way.
ben-allen
force-pushed
the
weekofyear-only-in-iso-8601
branch
from
ba3b432 to
634d139
Compare
using non-ISO calendar with `PlainDate`, `PlainDateTime`, and `ZonedDateTime`
ben-allen
force-pushed
the
weekofyear-only-in-iso-8601
branch
from
634d139 to
e6d760c
Compare
ptomato
approved these changes
Nov 19, 2025
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
LGTM, just remove islamicc from each list - it's an alias so doesn't need to be tested directly.
| "islamic-civil", | ||
| "islamic-tbla", | ||
| "islamic-umalqura", | ||
| "islamicc", |
Contributor
There was a problem hiding this comment.
Suggested change
| "islamicc", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests to Temporal.PlainDate, Temporal.PlainDateTime, and Temporal.ZonedDateTime ensuring weekOfYear only defined for "iso8601" calendar