Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call assert.deepEqual.format when the assertion will succeed #4358

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Don't call assert.deepEqual.format when the assertion will succeed #4358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions harness/deepEqual.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,15 @@ defines: [assert.deepEqual]

assert.deepEqual = function(actual, expected, message) {
var format = assert.deepEqual.format;
assert(
assert.deepEqual._compare(actual, expected),
`Expected ${format(actual)} to be structurally equal to ${format(expected)}. ${(message || '')}`
);
var mustBeTrue = assert.deepEqual._compare(actual, expected);

// format can be slow when `actual` or `expected` are large objects, like for
// example the global object, so only call it when the assertion will fail.
if (mustBeTrue !== true) {
message = `Expected ${format(actual)} to be structurally equal to ${format(expected)}. ${(message || '')}`;
}

assert(mustBeTrue, message);
};

(function() {
Expand Down
Loading