Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI improvements #4307

Merged
merged 10 commits into from
Nov 12, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove ci_lint.sh
After the previous commit, it doesn't do much, only passes the linting
exceptions file on the command line. Instead, make the lint.exceptions
file the default for that argument (if it exists), and remove the shell
script.
  • Loading branch information
ptomato committed Nov 11, 2024
commit f67597a697fea3e8a17ab015d1c3559ce17e088d
2 changes: 1 addition & 1 deletion .github/workflows/checks-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ jobs:
run: ./tools/lint/test/run.py

- name: Lint all tests
run: ./tools/scripts/ci_lint.sh
run: ./tools/lint/lint.py test/
2 changes: 1 addition & 1 deletion .github/workflows/checks-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,4 @@ jobs:
for file in $CHANGED; do
echo $file
done
./tools/scripts/ci_lint.sh $CHANGED
./tools/lint/lint.py $CHANGED
6 changes: 5 additions & 1 deletion tools/lint/lint.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,11 @@ def lint(file_names, features):
if args.exceptions:
exceptions = lib.exceptions.parse(args.exceptions)
else:
exceptions = dict()
try:
with open('lint.exceptions', 'r') as default_exceptions:
exceptions = lib.exceptions.parse(default_exceptions)
except FileNotFoundError:
exceptions = dict()

files = [path for _path in args.path for path in collect_files(_path)]
file_count = len(files)
Expand Down
7 changes: 0 additions & 7 deletions tools/scripts/ci_lint.sh

This file was deleted.