Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove incorrect property access in Promise.try test #4085

Merged
merged 1 commit into from
May 17, 2024
Merged

Remove incorrect property access in Promise.try test #4085

merged 1 commit into from
May 17, 2024

Conversation

sosukesuzuki
Copy link
Contributor

@sosukesuzuki sosukesuzuki commented May 17, 2024 •
edited
Loading

Removes incorrect property access (Promise/try/ctx-ctor.js)

@sosukesuzuki sosukesuzuki requested a review from a team as a code owner May 17, 2024 12:49
@sosukesuzuki sosukesuzuki force-pushed the fifx-promise-try-tests-2 branch from a58a40f to 3d3df6e Compare May 17, 2024 12:58
@sosukesuzuki sosukesuzuki changed the title Fix tests for Promise.try Remove incorrect property access in Promise.try test May 17, 2024
ljharb
ljharb approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this was obv a copy paste error :-)

@ljharb ljharb merged commit d9c6732 into tc39:main May 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sosukesuzuki @ljharb