Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[explicit-resource-management] Add move and disposed getter #4083

Merged
merged 2 commits into from
May 21, 2024
Merged

[explicit-resource-management] Add move and disposed getter #4083

merged 2 commits into from
May 21, 2024

Conversation

test262-pr-bot
Copy link

This CL adds move() function and a getter for disposed to
DisposableStack prototype.

Bug: 42203506
Change-Id: I8d7750b1d4aa199ebeb997bde7fe6d06c9ccbff0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5528992
Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#93931}

@rmahdav
[explicit-resource-management] Add move and disposed getter
fb7ab87 
This CL adds move() function and a getter for disposed to
DisposableStack prototype.

Bug: 42203506
Change-Id: I8d7750b1d4aa199ebeb997bde7fe6d06c9ccbff0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5528992
Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#93931}
@test262-pr-bot test262-pr-bot requested review from a team as code owners May 15, 2024 20:19
test262-merge-bot
test262-merge-bot approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

@ptomato
Copy link
Contributor

ptomato commented May 16, 2024

It's OK mergebot, we get it 😂

test262-merge-bot
test262-merge-bot approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

test262-merge-bot
test262-merge-bot approved these changes May 19, 2024
View reviewed changes
Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

@test262-merge-bot
Copy link
Contributor

Manual merge by liviurau@google.com via test262-merge-bot acocunt.

@test262-merge-bot test262-merge-bot merged commit 9c94de6 into main May 21, 2024
7 of 8 checks passed
@test262-merge-bot test262-merge-bot deleted the chromium-export-7eb56ce860 branch May 21, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@test262-merge-bot test262-merge-bot test262-merge-bot approved these changes

Assignees
No one assigned
Labels
v8-export
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@test262-pr-bot @ptomato @test262-merge-bot @rmahdav