Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporal: ZonedDateTime::round incorrect results with smallestUnit:day #4021

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

arshaw
Copy link
Contributor

@arshaw arshaw commented Mar 22, 2024

Adjusting tests for this issue, "ZonedDateTime::round incorrect results with smallestUnit:day" :
tc39/proposal-temporal#2797

Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks. This looks ready to merge as soon as the normative change is approved.

@ptomato ptomato added has consensus This has committee consensus and removed awaiting specification labels Apr 8, 2024
@ptomato ptomato enabled auto-merge (rebase) April 8, 2024 22:31
@ptomato
Copy link
Contributor

ptomato commented Apr 8, 2024

The normative change reached consensus in today's TC39 meeting.

@ptomato ptomato force-pushed the temporal-2790-round-zdt-day branch from efee7ea to b552e33 Compare April 9, 2024 01:21
@ptomato ptomato merged commit 6c60904 into tc39:main Apr 9, 2024
8 checks passed
@ptomato ptomato deleted the temporal-2790-round-zdt-day branch April 9, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has consensus This has committee consensus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants