Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test/built-ins/Object to use verifyProperty function #3935

Merged
merged 5 commits into from
Feb 29, 2024
Merged

Update test/built-ins/Object to use verifyProperty function #3935

merged 5 commits into from
Feb 29, 2024

Conversation

anba
Copy link
Contributor

@anba anba commented Sep 28, 2023

Update test/built-ins/Object to use the verifyProperty harness function. The changes are similar to #3916.

@anba anba requested a review from a team as a code owner September 28, 2023 14:01
@ljharb ljharb mentioned this pull request Oct 4, 2023
Draft
@ljharb ljharb self-assigned this Oct 25, 2023
ljharb
ljharb reviewed Oct 25, 2023
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a great improvement!

It would be ideal to remove all trailing object commas from the additions in this PR, but we can also do that with eslint later since that might be an annoying ask.

test/built-ins/Object/create/15.2.3.5-4-315.js Show resolved Hide resolved
test/built-ins/Object/defineProperties/15.2.3.7-6-a-110.js Show resolved Hide resolved
test/built-ins/Object/defineProperties/15.2.3.7-6-a-221.js Show resolved Hide resolved
test/built-ins/Object/defineProperties/15.2.3.7-6-a-221.js Show resolved Hide resolved
test/built-ins/Object/defineProperties/15.2.3.7-6-a-5.js Show resolved Hide resolved
test/built-ins/Object/seal/object-seal-all-own-properties-of-o-are-already-non-configurable.js Show resolved Hide resolved
test/built-ins/Object/seal/object-seal-all-own-properties-of-o-are-already-non-configurable.js Show resolved Hide resolved
...seal/object-seal-p-is-own-accessor-property-that-overrides-an-inherited-accessor-property.js Show resolved Hide resolved
test/built-ins/Object/seal/object-seal-p-is-own-accessor-property.js Show resolved Hide resolved
...ect/seal/object-seal-p-is-own-accessor-property-that-overrides-an-inherited-data-property.js Show resolved Hide resolved
ljharb
ljharb approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should get another stamp before merging, since it's so large

ptomato
ptomato approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed this. Of course updating old code always carries a risk, but I think this is a good update. Thanks for doing it!

@ptomato ptomato merged commit 62626e0 into tc39:main Feb 29, 2024
9 checks passed
@anba anba deleted the verifyprop-object branch June 24, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptomato ptomato ptomato approved these changes

@ljharb ljharb ljharb approved these changes

Assignees

@ljharb ljharb

Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anba @ljharb @ptomato