Move test which depends on TimeZone to intl402#3286
Move test which depends on TimeZone to intl402#3286FrankYFTang wants to merge 1 commit intotc39:mainfrom
Conversation
|
@Ms2ger @jugglinmike @ryzokuken @ljharb @ptomato @pipobscure It is actually pretty hard to tell which tests actually should/will work if the implementation only support UTC but not other timezone so I move all of them to intl402. For v8, we need to support two kind of compilation, one with full i18n support, one without i18n support. The one with i18n support will test against bulit-ins and intl402, the one without i18n support only need to test against built-ins. |
|
Thanks, I think I would like to take a closer look at these and split out the parts which don't depend on i18n support though, like you did in #3285. I don't mind adding this to my to-do list if you would prefer to concentrate on other things. |
|
@FrankYFTang sorry, can you fix the conflict? Thanks! |
0ed4e00 to
a3bc04e
Compare
|
resolve conflicts |
|
@ptomato I'm going to hold off on merging until I get a signal from you. Have you done the work you described on Oct 29? |
|
@rwaldron I haven't had a chance to do that yet, sorry. How high is the priority on your side? I'll try to prioritize it accordingly. |
|
@ptomato it's "whenever you get to it" ;) |
|
I believe this can be closed now. |
Temporal proposal only require the implementation to support "UTC" TimeZone unless they also support ECMA402, therefore, we have to move these tests to intl402.