Skip to content

Move test which depends on TimeZone to intl402#3286

Closed
FrankYFTang wants to merge 1 commit intotc39:mainfrom
FrankYFTang:MvIntl402
Closed

Move test which depends on TimeZone to intl402#3286
FrankYFTang wants to merge 1 commit intotc39:mainfrom
FrankYFTang:MvIntl402

Conversation

@FrankYFTang
Copy link
Contributor

Temporal proposal only require the implementation to support "UTC" TimeZone unless they also support ECMA402, therefore, we have to move these tests to intl402.

@FrankYFTang
Copy link
Contributor Author

FrankYFTang commented Oct 28, 2021

@Ms2ger @jugglinmike @ryzokuken @ljharb @ptomato @pipobscure

It is actually pretty hard to tell which tests actually should/will work if the implementation only support UTC but not other timezone so I move all of them to intl402. For v8, we need to support two kind of compilation, one with full i18n support, one without i18n support. The one with i18n support will test against bulit-ins and intl402, the one without i18n support only need to test against built-ins.

@ptomato
Copy link
Contributor

ptomato commented Oct 29, 2021

Thanks, I think I would like to take a closer look at these and split out the parts which don't depend on i18n support though, like you did in #3285. I don't mind adding this to my to-do list if you would prefer to concentrate on other things.

@rwaldron
Copy link
Contributor

@FrankYFTang sorry, can you fix the conflict? Thanks!

@FrankYFTang
Copy link
Contributor Author

resolve conflicts

@rwaldron
Copy link
Contributor

rwaldron commented Dec 4, 2021

@ptomato I'm going to hold off on merging until I get a signal from you. Have you done the work you described on Oct 29?

@ptomato
Copy link
Contributor

ptomato commented Dec 6, 2021

@rwaldron I haven't had a chance to do that yet, sorry. How high is the priority on your side? I'll try to prioritize it accordingly.

@rwaldron
Copy link
Contributor

@ptomato it's "whenever you get to it" ;)

@ptomato
Copy link
Contributor

ptomato commented Jan 12, 2022

@rwaldron I've opened #3377 for that, I think we can consider it to supersede this PR.

@ptomato
Copy link
Contributor

ptomato commented Jan 20, 2022

I believe this can be closed now.

@FrankYFTang FrankYFTang deleted the MvIntl402 branch July 21, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants