Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform compareArray -> assert.compareArray: test/built-ins/Array/**/*.js #3238

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Transform compareArray -> assert.compareArray: test/built-ins/Array/**/*.js #3238

merged 1 commit into from
Oct 8, 2021

Conversation

rwaldron
Copy link
Contributor

@rwaldron rwaldron commented Oct 5, 2021

No description provided.

@rwaldron rwaldron requested a review from jugglinmike October 5, 2021 16:36
jugglinmike
jugglinmike requested changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@jugglinmike jugglinmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another case of outdated assertion messages. Removing these will cut down on the noise, as well

@rwaldron rwaldron force-pushed the rwaldron/migrate-comparearray-001 branch from a1cb4ae to b79b0be Compare October 6, 2021 18:29
@rwaldron
Copy link
Contributor Author

rwaldron commented Oct 6, 2021

@jugglinmike fixed

@rwaldron rwaldron requested a review from jugglinmike October 6, 2021 18:30
@rwaldron
Copy link
Contributor Author

rwaldron commented Oct 6, 2021

These CI failures are for generated tests, which there are none of in this PR

@rwaldron rwaldron force-pushed the rwaldron/migrate-comparearray-001 branch from b79b0be to 1b9bd83 Compare October 6, 2021 19:48
@jugglinmike jugglinmike merged commit fc975b1 into main Oct 8, 2021
@jugglinmike jugglinmike deleted the rwaldron/migrate-comparearray-001 branch October 8, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jugglinmike jugglinmike jugglinmike approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwaldron @jugglinmike