-
Notifications
You must be signed in to change notification settings - Fork 503
Add test for [[Description]] from Symbol.for
#2970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
is stringKey. | ||
[...] | ||
6. Return newSymbol. | ||
features: [Symbol] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
features: [Symbol] | |
features: [Symbol, Symbol.prototype.description] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jugglinmike The test looks good and it is just missing the feature tag as pointed out by @shvaikalesh.
A small nit pick, thou. I believe this test file should be at test/built-ins/Symbol/prototype/description and that folder might be missing other tests to capture description from ToString coerced values.
The decision on the file location might be subjective and it's ok to not go through that path.
Thanks for reviewing this!
All set
Yeah, the test necessarily uses two different APIs, making the placement a little ambiguous. I chose the
I can help with that. I don't see any string coercion in that algorithm, though--could you say more about what you have in mind? |
@leobalter are you good with @jugglinmike's response? |
Yes, I just don't have the bandwidth to expand my thoughts on the ToString coercion, but hopefully I can explore it in a near future. |
Thanks, @leobalter! Would you mind formally registering your approval using the GitHub.com UI? At some point, this became mandatory for Test262 pull requests. |
Resolves gh-2967. I reviewed the project's coverage for the rest of this algorithm, and it looks okay to me.