Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterator Helpers #2818

Merged
merged 68 commits into from
Jun 15, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
846527d
AsyncIterator, pt 1
rwaldron Dec 2, 2021
fb1ec43
AsyncIterator, pt 1
rwaldron Sep 24, 2020
3cbd492
AsyncIterator, pt 2
rwaldron Nov 4, 2020
d11190b
AsyncIterator, pt 3
rwaldron Dec 2, 2020
796d915
AsyncIterator, pt 4
rwaldron Dec 2, 2020
4d84bb5
Lint fix
rwaldron Dec 2, 2020
1ffd654
WIP: split iterator helpers proposal into sync/async
michaelficarra Mar 8, 2023
a77da9d
WIP: split iterator helpers proposal into sync/async (drop)
michaelficarra Mar 9, 2023
738e83c
delete asIndexedPairs
michaelficarra Mar 9, 2023
c664108
WIP: split iterator helpers proposal into sync/async (find)
michaelficarra Mar 10, 2023
7bbdc23
WIP: split iterator helpers proposal into sync/async (filter)
michaelficarra Mar 10, 2023
f37c41d
drop
michaelficarra Mar 11, 2023
ee73f08
more drop tests
michaelficarra Mar 13, 2023
7d93b51
more every tests
michaelficarra Mar 14, 2023
1731b9e
finish drop/every
michaelficarra Mar 14, 2023
c240314
missed some
michaelficarra Mar 15, 2023
5961825
more drop/every tests
michaelficarra Mar 16, 2023
9cb3763
another drop/every test
michaelficarra Mar 16, 2023
2d9724e
filter tests
michaelficarra Mar 16, 2023
8394ceb
remove find tests that I'm not going to use
michaelficarra Mar 16, 2023
26c7463
remove Test262AsyncIterator
michaelficarra Mar 18, 2023
7078f1b
remove unused vars
michaelficarra Mar 18, 2023
625ba33
fixup: Apply suggestions from code review
ljharb Mar 22, 2023
b9fd34d
fixup: fix Object toString test
ljharb Mar 25, 2023
3d83a24
add another this/arguments order assertion
michaelficarra Mar 30, 2023
4df6042
add more assertions for forwarding return only once
michaelficarra Mar 30, 2023
0fbe8e2
start of flatMap tests
michaelficarra Mar 31, 2023
e4aa3b3
use verifyProperty
michaelficarra Apr 24, 2023
188b5cc
remove IteratorPrototype
michaelficarra Apr 24, 2023
1daf454
address review comments
michaelficarra Apr 24, 2023
cdbdbee
add some more flatMap tests
michaelficarra Apr 25, 2023
cdf7237
remove unused includes
michaelficarra Apr 25, 2023
dee5d01
remove empty includes
michaelficarra Apr 25, 2023
a50a903
missed one
michaelficarra Apr 25, 2023
d9f1a78
more flatMap tests
michaelficarra Apr 25, 2023
eab8870
add tests for take
michaelficarra Apr 25, 2023
c203788
fix up some things I noticed while writing take tests
michaelficarra Apr 25, 2023
71aa978
remove Test262Iterator helper
michaelficarra Apr 26, 2023
bf25cae
add some step references to flatMap descriptions
michaelficarra Apr 26, 2023
13f20cf
fix broken take test
michaelficarra Apr 28, 2023
3caff9a
add tests for some
michaelficarra Apr 29, 2023
da7cfa2
add tests for map
michaelficarra May 4, 2023
73c93df
add test for forEach
michaelficarra May 5, 2023
e0ffa73
add descriptions about non-constructibility
michaelficarra May 22, 2023
412bcf6
https://github.com/tc39/proposal-iterator-helpers/pull/274
michaelficarra May 22, 2023
8b49bf4
https://github.com/tc39/proposal-iterator-helpers/pull/272
michaelficarra May 22, 2023
8e4974b
add tests for non-constructibility with no arguments
michaelficarra May 22, 2023
dfdd47a
typo
michaelficarra May 22, 2023
1dc86d8
typo
michaelficarra May 22, 2023
61e8521
Iterator.from tests
michaelficarra May 22, 2023
66f41b8
tests for `find`
michaelficarra May 23, 2023
43dc6bf
remove useless assertion messages
michaelficarra May 23, 2023
3c42624
run prettier
michaelficarra May 23, 2023
901f8b1
test for Symbol.toStringTag
michaelficarra May 23, 2023
ffb5f7c
fix length descriptions
michaelficarra May 23, 2023
224854c
remove tautological assertions from property descriptor tests
michaelficarra May 23, 2023
4c2a096
remove more useless assertion messages
michaelficarra May 23, 2023
ed0909a
add toArray tests
michaelficarra May 23, 2023
d39135d
improve the throws-then-closing-iterator-also-throws tests
michaelficarra May 25, 2023
6653018
use prefix increments
michaelficarra May 25, 2023
1f3ac12
add tests for reduce
michaelficarra May 25, 2023
d0913b4
review feedback
michaelficarra May 25, 2023
0d04ba7
don't rely on Iterator global in Symbol.iterator tests
michaelficarra May 31, 2023
b36d1d5
add iteator-helpers feature flag to Symbol.toStringTag test
michaelficarra May 31, 2023
03b56c5
fix broken frontmatter in proto-from-ctor-realm.js
michaelficarra May 31, 2023
6ee276a
fix another leftover Iterator.prototype
michaelficarra Jun 12, 2023
523e08c
Merge branch 'main' into iterator-helpers
michaelficarra Jun 12, 2023
30f9dcf
Merge branch 'main' into iterator-helpers
ptomato Jun 15, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove IteratorPrototype
  • Loading branch information
michaelficarra committed May 31, 2023
commit 188b5cc2bf105fd1b7a5267278de45012fd13b03
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// This code is governed by the BSD license found in the LICENSE file.
/*---
es6id: 25.1.2.1
description: Length of IteratorPrototype[ @@iterator ]
description: Length of %IteratorPrototype%[ @@iterator ]
info: |
ES6 Section 17:
Every built-in Function object, including constructors, has a length
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,14 @@
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-%iteratorprototype%-@@iterator
description: Return value of @@iterator on IteratorPrototype
description: Return value of @@iterator on %IteratorPrototype%
info: |
%IteratorPrototype% [ @@iterator ] ( )
1. Return the this value.
features: [Symbol.iterator]
---*/

const IteratorPrototype = Object.getPrototypeOf(
Object.getPrototypeOf([][Symbol.iterator]())
);
const getIterator = IteratorPrototype[Symbol.iterator];
const getIterator = Iterator.prototype[Symbol.iterator];

const thisValues = [
{},
Expand Down