Assign "name" property to all anonymous functions #2299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the changes from <tc39/ecma262#1490>.
Member
|
That's awesome, thank you! cc @caiolima if you're working on the tests for class elements this ref PR in ECMA-262 might affect them as well. |
leobalter
approved these changes
Aug 15, 2019
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Aug 20, 2019
Update test262 to get the changes from <tc39/test262#2299>. Differential Revision: https://phabricator.services.mozilla.com/D42158 --HG-- rename : js/src/tests/test262/language/statements/class/elements/prviate-accessor-is-visible-in-computed-properties.js => js/src/tests/test262/language/statements/class/elements/private-accessor-is-visible-in-computed-properties.js rename : js/src/tests/test262/language/statements/class/elements/prviate-method-is-visible-in-computed-properties.js => js/src/tests/test262/language/statements/class/elements/private-method-is-visible-in-computed-properties.js extra : moz-landing-system : lando
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Aug 20, 2019
Update test262 to get the changes from <tc39/test262#2299>. Differential Revision: https://phabricator.services.mozilla.com/D42158 --HG-- rename : js/src/tests/test262/language/statements/class/elements/prviate-accessor-is-visible-in-computed-properties.js => js/src/tests/test262/language/statements/class/elements/private-accessor-is-visible-in-computed-properties.js rename : js/src/tests/test262/language/statements/class/elements/prviate-method-is-visible-in-computed-properties.js => js/src/tests/test262/language/statements/class/elements/private-method-is-visible-in-computed-properties.js extra : source : de51f104550cb6838cc24ae198a28828ff8b384a
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Aug 20, 2019
Update test262 to get the changes from <tc39/test262#2299>. Differential Revision: https://phabricator.services.mozilla.com/D42158
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Aug 20, 2019
Update test262 to get the changes from <tc39/test262#2299>. Differential Revision: https://phabricator.services.mozilla.com/D42158
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
Update test262 to get the changes from <tc39/test262#2299>. Differential Revision: https://phabricator.services.mozilla.com/D42158 UltraBlame original commit: de51f104550cb6838cc24ae198a28828ff8b384a
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
Update test262 to get the changes from <tc39/test262#2299>. Differential Revision: https://phabricator.services.mozilla.com/D42158 UltraBlame original commit: bc2a756c45543000ebae9cc907f8170326a950c5
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
Update test262 to get the changes from <tc39/test262#2299>. Differential Revision: https://phabricator.services.mozilla.com/D42158 UltraBlame original commit: de51f104550cb6838cc24ae198a28828ff8b384a
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
Update test262 to get the changes from <tc39/test262#2299>. Differential Revision: https://phabricator.services.mozilla.com/D42158 UltraBlame original commit: bc2a756c45543000ebae9cc907f8170326a950c5
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
Update test262 to get the changes from <tc39/test262#2299>. Differential Revision: https://phabricator.services.mozilla.com/D42158 UltraBlame original commit: de51f104550cb6838cc24ae198a28828ff8b384a
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
Update test262 to get the changes from <tc39/test262#2299>. Differential Revision: https://phabricator.services.mozilla.com/D42158 UltraBlame original commit: bc2a756c45543000ebae9cc907f8170326a950c5
StenCalDabran
added a commit
to StenCalDabran/node
that referenced
this pull request
Dec 15, 2020
Original commit message:
Install "name" property on anonymous classes
This is a normative PR that reached consensus at the June 2019 TC39:
tc39/test262#2299
Bug: v8:9646
Change-Id: I8cb927b9e9231dfb71ebf47171205a096350e38b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2360905
Reviewed-by: Marja Hölttä <marja@chromium.org>
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69460}
Refs: v8/v8@048761a
Closes: nodejs#36038
targos
pushed a commit
to StenCalDabran/node
that referenced
this pull request
Apr 24, 2021
Original commit message:
Install "name" property on anonymous classes
This is a normative PR that reached consensus at the June 2019 TC39:
tc39/test262#2299
Bug: v8:9646
Change-Id: I8cb927b9e9231dfb71ebf47171205a096350e38b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2360905
Reviewed-by: Marja Hölttä <marja@chromium.org>
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69460}
Refs: v8/v8@048761a
Closes: nodejs#36038
bhearsum
pushed a commit
to mozilla-releng/staging-firefox
that referenced
this pull request
May 1, 2025
Update test262 to get the changes from <tc39/test262#2299>. Differential Revision: https://phabricator.services.mozilla.com/D42158
bhearsum
pushed a commit
to mozilla-releng/staging-firefox
that referenced
this pull request
May 1, 2025
Update test262 to get the changes from <tc39/test262#2299>. Differential Revision: https://phabricator.services.mozilla.com/D42158
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the changes from tc39/ecma262#1490.