Add tests for Proxy semantics change #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shvaikalesh
force-pushed
the
proxy-change-666
branch
from
f51de43
to
f5cd4f9
Compare
shvaikalesh
force-pushed
the
proxy-change-666
branch
from
104e595
to
f150ac5
Compare
shvaikalesh
force-pushed
the
proxy-change-666
branch
from
f150ac5
to
9fa9fc0
Compare
leobalter
previously approved these changes
May 1, 2019
test/built-ins/Proxy/defineProperty/targetdesc-not-configurable-writable-desc-not-writable.js
Outdated
Show resolved
Hide resolved
test/built-ins/Proxy/defineProperty/targetdesc-not-configurable-writable-desc-not-writable.js
Show resolved
Hide resolved
test/built-ins/Proxy/defineProperty/targetdesc-not-configurable-writable-desc-not-writable.js
Outdated
Show resolved
Hide resolved
test/built-ins/Proxy/deleteProperty/targetdesc-is-configurable-target-is-not-extensible.js
Outdated
Show resolved
Hide resolved
test/built-ins/Proxy/deleteProperty/targetdesc-is-configurable-target-is-not-extensible.js
Outdated
Show resolved
Hide resolved
...tOwnPropertyDescriptor/resultdesc-is-not-configurable-not-writable-targetdesc-is-writable.js
Outdated
Show resolved
Hide resolved
...tOwnPropertyDescriptor/resultdesc-is-not-configurable-not-writable-targetdesc-is-writable.js
Outdated
Show resolved
Hide resolved
test/built-ins/Proxy/deleteProperty/targetdesc-is-configurable-target-is-not-extensible.js
Show resolved
Hide resolved
shvaikalesh
force-pushed
the
proxy-change-666
branch
from
63026bb
to
17ed315
Compare
|
Thanks for detailed feedback, @leobalter. Instead of duplicating tests, I've moved property definitions to traps just like we have in some other tests. Except for asserting that |
leobalter
suggested changes
May 2, 2019
test/built-ins/Proxy/deleteProperty/targetdesc-is-configurable-target-is-not-extensible.js
Outdated
Show resolved
Hide resolved
test/built-ins/Proxy/deleteProperty/targetdesc-is-configurable-target-is-not-extensible.js
Outdated
Show resolved
Hide resolved
|
These tests are great! Thanks! |
leobalter
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec PR: tc39/ecma262#666.
Closes #2142.