Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for export * as ns from 'foo' syntax #1498

Merged
merged 10 commits into from
Jun 28, 2018
Merged

Conversation

spectranaut
Copy link
Contributor

@spectranaut spectranaut commented Mar 19, 2018

Tests for this PR: tc39/ecma262#1005
Now this PR: tc39/ecma262#1174

One or two more commits of tests to come.

@@ -22,3 +22,5 @@ export { indirectIdName } from './instn-star-props-nrml-indirect_FIXTURE.js';
export { indirectIdName as indirectIdName2 } from './instn-star-props-nrml-indirect_FIXTURE.js';

export * from './instn-star-props-nrml-star_FIXTURE.js';

export * as exportns from './instn-star-props-nrml-star-as-exportns_FIXTURE.js';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you will still split this part into a new file?

same for test/language/module-code/instn-star-props-nrml.js

In this case, tests LGTM.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually really not sure what you are asking, @leobalter

@rwaldron
Copy link
Contributor

rwaldron commented Apr 3, 2018

@spectranaut is this still "WIP", or ready to land?

@spectranaut
Copy link
Contributor Author

spectranaut commented Apr 3, 2018

Hey @rwaldron -- don't land, we are still waiting for the spec change PR.

@rwaldron
Copy link
Contributor

rwaldron commented Apr 3, 2018

@spectranaut got it, thanks!

@ljharb
Copy link
Member

ljharb commented Apr 18, 2018

Can the title be updated to indicate it’s no longer WIP, since the label now indicates it’s not yet ready to land?

@leobalter leobalter changed the title WIP: tests for export * as ns from 'foo' syntax Tests for export * as ns from 'foo' syntax Apr 18, 2018
@spectranaut spectranaut force-pushed the export-ns-from branch 2 times, most recently from ec88bf0 to 4c6bb69 Compare April 20, 2018 17:31
@spectranaut
Copy link
Contributor Author

@rwaldron @leobalter -- I've added the feature tag, so I believe it is ok to merge?

@ljharb
Copy link
Member

ljharb commented Jun 7, 2018

This seems like it needs a rebase first.

@leobalter
Copy link
Member

Rebasing and merging

@leobalter leobalter merged commit 2fa8fc4 into tc39:master Jun 28, 2018
@leobalter leobalter deleted the export-ns-from branch June 28, 2018 19:46

var x;
export default x;
export * as default from 'early-dup-export-start-as-dflt.js';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make sense to have a positive test case for export * as default from.

@adrianheine
Copy link
Contributor

For parser testing, I think it makes sense to have another positive test case for export * as [reserved word] from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants