Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String.prototype.{ trimStart, trimEnd, trimLeft, trimRight } tests #1246

Closed
wants to merge 21 commits into from
Closed

String.prototype.{ trimStart, trimEnd, trimLeft, trimRight } tests #1246

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
f6fba77
Add initial tests for trim(Start/End/Left/Right)
Sep 25, 2017
b532507
Add object coercible tests for trim(start/End)
Sep 25, 2017
2250dac
Add boolean/Symbol() tests for trim(Start/End)
Sep 25, 2017
ead4335
fixup: Add initial tests for trim(Start/End/Left/Right)
Sep 29, 2017
e3e97f7
Fixup: Add object coercible tests for trim(start/End)
Sep 29, 2017
5daafd8
fixup: Add boolean/Symbol() tests for trim(Start/End)
Sep 29, 2017
8e5f5ac
Add number tests for trim(Start/End)
Sep 29, 2017
a279432
Add feature: string-trimming
Oct 2, 2017
1fbd770
Add tests for sucessful whitespace removing
Oct 2, 2017
db51688
Add ToPrimitive method priority testing
Oct 3, 2017
55a82a9
fix typos
Oct 3, 2017
104f4bf
Completely rewrite ToPrimitive method priority testing
Oct 4, 2017
aeadb9e
Add test of object without to primitive functionality
Oct 4, 2017
6bfbf95
Add tests for object to primitive call errors
Oct 4, 2017
7c1aa35
Add tests for object to primitive method errors
Oct 4, 2017
d852e17
Add tests for object to primitive returns object errors
Oct 4, 2017
ebef322
Add reference tests for trimLeft and trimRight
Oct 4, 2017
ccf5abc
Fixup typos
Oct 6, 2017
7b0bd99
Add this value object testing to trimEnd
Oct 6, 2017
78549f6
Fixup edit to info
Oct 6, 2017
142b14a
Merge branch 'master' into trims
rwaldron Jan 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixup: Add object coercible tests for trim(start/End)
  • Loading branch information
Valerie R Young authored and Valerie R Young committed Oct 4, 2017
commit e3e97f75d7c2b15f334f591d3516cddebf04d81b
3 changes: 2 additions & 1 deletion test/built-ins/String/prototype/trimEnd/this-value-not-obj-coercible.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@
// This code is governed by the BSD license found in the LICENSE file.

/*---
esid: pending
esid: sec-string.prototype.trimEnd
description: The "this" value must be object-coercible
info: |
1. Let O be ? RequireObjectCoercible(this value).
features: [string-trimming]
---*/

var trimEnd = String.prototype.trimEnd;
Expand Down
3 changes: 2 additions & 1 deletion test/built-ins/String/prototype/trimStart/this-value-not-obj-coercible.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@
// This code is governed by the BSD license found in the LICENSE file.

/*---
esid: pending
esid: sec-string.prototype.trimStart
description: The "this" value must be object-coercible
info: |
1. Let O be ? RequireObjectCoercible(this value).
features: [string-trimming]
---*/

var trimStart = String.prototype.trimStart;
Expand Down